bug366 (missed optimization)

Percentage Accurate: 45.6% → 98.3%

Time: 10.3s

Alternatives: 2

Speedup: 4.3×

Specification

Math

\[\begin{array}{l} \\ \sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \end{array} \]

FPCore

(FPCore (x y z) :precision binary64 (sqrt (+ (* x x) (+ (* y y) (* z z)))))

C

double code(double x, double y, double z) {
	return sqrt(((x * x) + ((y * y) + (z * z))));
}

Fortran

module fmin_fmax_functions
    implicit none
    private
    public fmax
    public fmin

    interface fmax
        module procedure fmax88
        module procedure fmax44
        module procedure fmax84
        module procedure fmax48
    end interface
    interface fmin
        module procedure fmin88
        module procedure fmin44
        module procedure fmin84
        module procedure fmin48
    end interface
contains
    real(8) function fmax88(x, y) result (res)
        real(8), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(x, max(x, y), y /= y), x /= x)
    end function
    real(4) function fmax44(x, y) result (res)
        real(4), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(y, merge(x, max(x, y), y /= y), x /= x)
    end function
    real(8) function fmax84(x, y) result(res)
        real(8), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(dble(y), merge(x, max(x, dble(y)), y /= y), x /= x)
    end function
    real(8) function fmax48(x, y) result(res)
        real(4), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(dble(x), max(dble(x), y), y /= y), x /= x)
    end function
    real(8) function fmin88(x, y) result (res)
        real(8), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(x, min(x, y), y /= y), x /= x)
    end function
    real(4) function fmin44(x, y) result (res)
        real(4), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(y, merge(x, min(x, y), y /= y), x /= x)
    end function
    real(8) function fmin84(x, y) result(res)
        real(8), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(dble(y), merge(x, min(x, dble(y)), y /= y), x /= x)
    end function
    real(8) function fmin48(x, y) result(res)
        real(4), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(dble(x), min(dble(x), y), y /= y), x /= x)
    end function
end module

real(8) function code(x, y, z)
use fmin_fmax_functions
    real(8), intent (in) :: x
    real(8), intent (in) :: y
    real(8), intent (in) :: z
    code = sqrt(((x * x) + ((y * y) + (z * z))))
end function

Java

public static double code(double x, double y, double z) {
	return Math.sqrt(((x * x) + ((y * y) + (z * z))));
}

Python

def code(x, y, z):
	return math.sqrt(((x * x) + ((y * y) + (z * z))))

Julia

function code(x, y, z)
	return sqrt(Float64(Float64(x * x) + Float64(Float64(y * y) + Float64(z * z))))
end

MATLAB

function tmp = code(x, y, z)
	tmp = sqrt(((x * x) + ((y * y) + (z * z))));
end

Wolfram

code[x_, y_, z_] := N[Sqrt[N[(N[(x * x), $MachinePrecision] + N[(N[(y * y), $MachinePrecision] + N[(z * z), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]], $MachinePrecision]

Initial Program: 45.6% accurate, 1.0× speedup

Math

\[\begin{array}{l} \\ \sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \end{array} \]

FPCore

(FPCore (x y z) :precision binary64 (sqrt (+ (* x x) (+ (* y y) (* z z)))))

C

double code(double x, double y, double z) {
	return sqrt(((x * x) + ((y * y) + (z * z))));
}

Fortran

module fmin_fmax_functions
    implicit none
    private
    public fmax
    public fmin

    interface fmax
        module procedure fmax88
        module procedure fmax44
        module procedure fmax84
        module procedure fmax48
    end interface
    interface fmin
        module procedure fmin88
        module procedure fmin44
        module procedure fmin84
        module procedure fmin48
    end interface
contains
    real(8) function fmax88(x, y) result (res)
        real(8), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(x, max(x, y), y /= y), x /= x)
    end function
    real(4) function fmax44(x, y) result (res)
        real(4), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(y, merge(x, max(x, y), y /= y), x /= x)
    end function
    real(8) function fmax84(x, y) result(res)
        real(8), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(dble(y), merge(x, max(x, dble(y)), y /= y), x /= x)
    end function
    real(8) function fmax48(x, y) result(res)
        real(4), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(dble(x), max(dble(x), y), y /= y), x /= x)
    end function
    real(8) function fmin88(x, y) result (res)
        real(8), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(x, min(x, y), y /= y), x /= x)
    end function
    real(4) function fmin44(x, y) result (res)
        real(4), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(y, merge(x, min(x, y), y /= y), x /= x)
    end function
    real(8) function fmin84(x, y) result(res)
        real(8), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(dble(y), merge(x, min(x, dble(y)), y /= y), x /= x)
    end function
    real(8) function fmin48(x, y) result(res)
        real(4), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(dble(x), min(dble(x), y), y /= y), x /= x)
    end function
end module

real(8) function code(x, y, z)
use fmin_fmax_functions
    real(8), intent (in) :: x
    real(8), intent (in) :: y
    real(8), intent (in) :: z
    code = sqrt(((x * x) + ((y * y) + (z * z))))
end function

Java

public static double code(double x, double y, double z) {
	return Math.sqrt(((x * x) + ((y * y) + (z * z))));
}

Python

def code(x, y, z):
	return math.sqrt(((x * x) + ((y * y) + (z * z))))

Julia

function code(x, y, z)
	return sqrt(Float64(Float64(x * x) + Float64(Float64(y * y) + Float64(z * z))))
end

MATLAB

function tmp = code(x, y, z)
	tmp = sqrt(((x * x) + ((y * y) + (z * z))));
end

Wolfram

code[x_, y_, z_] := N[Sqrt[N[(N[(x * x), $MachinePrecision] + N[(N[(y * y), $MachinePrecision] + N[(z * z), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]], $MachinePrecision]

Alternative 1: 98.3% accurate, 4.3× speedup

Math

\[\begin{array}{l} x_m = \left|x\right| \\ y_m = \left|y\right| \\ z_m = \left|z\right| \\ [x_m, y_m, z_m] = \mathsf{sort}([x_m, y_m, z_m])\\ \\ z\_m \cdot 1 \end{array} \]

FPCore

x_m = (fabs.f64 x)
y_m = (fabs.f64 y)
z_m = (fabs.f64 z)
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
(FPCore (x_m y_m z_m) :precision binary64 (* z_m 1.0))

C

x_m = fabs(x);
y_m = fabs(y);
z_m = fabs(z);
assert(x_m < y_m && y_m < z_m);
double code(double x_m, double y_m, double z_m) {
	return z_m * 1.0;
}

Fortran

x_m =     private
y_m =     private
z_m =     private
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
module fmin_fmax_functions
    implicit none
    private
    public fmax
    public fmin

    interface fmax
        module procedure fmax88
        module procedure fmax44
        module procedure fmax84
        module procedure fmax48
    end interface
    interface fmin
        module procedure fmin88
        module procedure fmin44
        module procedure fmin84
        module procedure fmin48
    end interface
contains
    real(8) function fmax88(x, y) result (res)
        real(8), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(x, max(x, y), y /= y), x /= x)
    end function
    real(4) function fmax44(x, y) result (res)
        real(4), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(y, merge(x, max(x, y), y /= y), x /= x)
    end function
    real(8) function fmax84(x, y) result(res)
        real(8), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(dble(y), merge(x, max(x, dble(y)), y /= y), x /= x)
    end function
    real(8) function fmax48(x, y) result(res)
        real(4), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(dble(x), max(dble(x), y), y /= y), x /= x)
    end function
    real(8) function fmin88(x, y) result (res)
        real(8), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(x, min(x, y), y /= y), x /= x)
    end function
    real(4) function fmin44(x, y) result (res)
        real(4), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(y, merge(x, min(x, y), y /= y), x /= x)
    end function
    real(8) function fmin84(x, y) result(res)
        real(8), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(dble(y), merge(x, min(x, dble(y)), y /= y), x /= x)
    end function
    real(8) function fmin48(x, y) result(res)
        real(4), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(dble(x), min(dble(x), y), y /= y), x /= x)
    end function
end module

real(8) function code(x_m, y_m, z_m)
use fmin_fmax_functions
    real(8), intent (in) :: x_m
    real(8), intent (in) :: y_m
    real(8), intent (in) :: z_m
    code = z_m * 1.0d0
end function

Java

x_m = Math.abs(x);
y_m = Math.abs(y);
z_m = Math.abs(z);
assert x_m < y_m && y_m < z_m;
public static double code(double x_m, double y_m, double z_m) {
	return z_m * 1.0;
}

Python

x_m = math.fabs(x)
y_m = math.fabs(y)
z_m = math.fabs(z)
[x_m, y_m, z_m] = sort([x_m, y_m, z_m])
def code(x_m, y_m, z_m):
	return z_m * 1.0

Julia

x_m = abs(x)
y_m = abs(y)
z_m = abs(z)
x_m, y_m, z_m = sort([x_m, y_m, z_m])
function code(x_m, y_m, z_m)
	return Float64(z_m * 1.0)
end

MATLAB

x_m = abs(x);
y_m = abs(y);
z_m = abs(z);
x_m, y_m, z_m = num2cell(sort([x_m, y_m, z_m])){:}
function tmp = code(x_m, y_m, z_m)
	tmp = z_m * 1.0;
end

Wolfram

x_m = N[Abs[x], $MachinePrecision]
y_m = N[Abs[y], $MachinePrecision]
z_m = N[Abs[z], $MachinePrecision]
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
code[x$95$m_, y$95$m_, z$95$m_] := N[(z$95$m * 1.0), $MachinePrecision]

Derivation

1. Initial program 45.6%

   \[\sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \]

2. Taylor expanded in z around inf

   \[\leadsto \color{blue}{z \cdot \left(1 + \frac{1}{2} \cdot \frac{{x}^{2} + {y}^{2}}{{z}^{2}}\right)} \]

4. Applied rewrites 82.3%

   \[\leadsto \color{blue}{z \cdot \left(1 + 0.5 \cdot \frac{{x}^{2} + {y}^{2}}{{z}^{2}}\right)} \]

5. Taylor expanded in z around inf

   \[\leadsto z \cdot 1 \]

7. Applied rewrites 98.3%

   \[\leadsto z \cdot 1 \]
8. Add Preprocessing

Alternative 2: 1.7% accurate, 8.7× speedup

Math

\[\begin{array}{l} x_m = \left|x\right| \\ y_m = \left|y\right| \\ z_m = \left|z\right| \\ [x_m, y_m, z_m] = \mathsf{sort}([x_m, y_m, z_m])\\ \\ -x\_m \end{array} \]

FPCore

x_m = (fabs.f64 x)
y_m = (fabs.f64 y)
z_m = (fabs.f64 z)
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
(FPCore (x_m y_m z_m) :precision binary64 (- x_m))

C

x_m = fabs(x);
y_m = fabs(y);
z_m = fabs(z);
assert(x_m < y_m && y_m < z_m);
double code(double x_m, double y_m, double z_m) {
	return -x_m;
}

Fortran

x_m =     private
y_m =     private
z_m =     private
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
module fmin_fmax_functions
    implicit none
    private
    public fmax
    public fmin

    interface fmax
        module procedure fmax88
        module procedure fmax44
        module procedure fmax84
        module procedure fmax48
    end interface
    interface fmin
        module procedure fmin88
        module procedure fmin44
        module procedure fmin84
        module procedure fmin48
    end interface
contains
    real(8) function fmax88(x, y) result (res)
        real(8), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(x, max(x, y), y /= y), x /= x)
    end function
    real(4) function fmax44(x, y) result (res)
        real(4), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(y, merge(x, max(x, y), y /= y), x /= x)
    end function
    real(8) function fmax84(x, y) result(res)
        real(8), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(dble(y), merge(x, max(x, dble(y)), y /= y), x /= x)
    end function
    real(8) function fmax48(x, y) result(res)
        real(4), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(dble(x), max(dble(x), y), y /= y), x /= x)
    end function
    real(8) function fmin88(x, y) result (res)
        real(8), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(x, min(x, y), y /= y), x /= x)
    end function
    real(4) function fmin44(x, y) result (res)
        real(4), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(y, merge(x, min(x, y), y /= y), x /= x)
    end function
    real(8) function fmin84(x, y) result(res)
        real(8), intent (in) :: x
        real(4), intent (in) :: y
        res = merge(dble(y), merge(x, min(x, dble(y)), y /= y), x /= x)
    end function
    real(8) function fmin48(x, y) result(res)
        real(4), intent (in) :: x
        real(8), intent (in) :: y
        res = merge(y, merge(dble(x), min(dble(x), y), y /= y), x /= x)
    end function
end module

real(8) function code(x_m, y_m, z_m)
use fmin_fmax_functions
    real(8), intent (in) :: x_m
    real(8), intent (in) :: y_m
    real(8), intent (in) :: z_m
    code = -x_m
end function

Java

x_m = Math.abs(x);
y_m = Math.abs(y);
z_m = Math.abs(z);
assert x_m < y_m && y_m < z_m;
public static double code(double x_m, double y_m, double z_m) {
	return -x_m;
}

Python

x_m = math.fabs(x)
y_m = math.fabs(y)
z_m = math.fabs(z)
[x_m, y_m, z_m] = sort([x_m, y_m, z_m])
def code(x_m, y_m, z_m):
	return -x_m

Julia

x_m = abs(x)
y_m = abs(y)
z_m = abs(z)
x_m, y_m, z_m = sort([x_m, y_m, z_m])
function code(x_m, y_m, z_m)
	return Float64(-x_m)
end

MATLAB

x_m = abs(x);
y_m = abs(y);
z_m = abs(z);
x_m, y_m, z_m = num2cell(sort([x_m, y_m, z_m])){:}
function tmp = code(x_m, y_m, z_m)
	tmp = -x_m;
end

Wolfram

x_m = N[Abs[x], $MachinePrecision]
y_m = N[Abs[y], $MachinePrecision]
z_m = N[Abs[z], $MachinePrecision]
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
code[x$95$m_, y$95$m_, z$95$m_] := (-x$95$m)

Derivation

1. Initial program 45.6%

   \[\sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \]

2. Taylor expanded in x around -inf

   \[\leadsto \color{blue}{-1 \cdot x} \]

4. Applied rewrites 1.7%

   \[\leadsto \color{blue}{-1 \cdot x} \]

6. Applied rewrites 1.7%

   \[\leadsto \color{blue}{-x} \]
7. Add Preprocessing

Reproduce

herbie shell --seed 2025153 
(FPCore (x y z)
  :name "bug366 (missed optimization)"
  :precision binary64
  (sqrt (+ (* x x) (+ (* y y) (* z z)))))