bug500, discussion (missed optimization)

Percentage Accurate: 52.8% → 97.2%
Time: 8.8s
Alternatives: 4
Speedup: 19.3×

Specification

?
\[\begin{array}{l} \\ \log \left(\frac{\sinh x}{x}\right) \end{array} \]
(FPCore (x) :precision binary64 (log (/ (sinh x) x)))
double code(double x) {
	return log((sinh(x) / x));
}
real(8) function code(x)
    real(8), intent (in) :: x
    code = log((sinh(x) / x))
end function
public static double code(double x) {
	return Math.log((Math.sinh(x) / x));
}
def code(x):
	return math.log((math.sinh(x) / x))
function code(x)
	return log(Float64(sinh(x) / x))
end
function tmp = code(x)
	tmp = log((sinh(x) / x));
end
code[x_] := N[Log[N[(N[Sinh[x], $MachinePrecision] / x), $MachinePrecision]], $MachinePrecision]
\begin{array}{l}

\\
\log \left(\frac{\sinh x}{x}\right)
\end{array}

Sampling outcomes in binary64 precision:

Local Percentage Accuracy vs ?

The average percentage accuracy by input value. Horizontal axis shows value of an input variable; the variable is choosen in the title. Vertical axis is accuracy; higher is better. Red represent the original program, while blue represents Herbie's suggestion. These can be toggled with buttons below the plot. The line is an average while dots represent individual samples.

Accuracy vs Speed?

Herbie found 4 alternatives:

AlternativeAccuracySpeedup
The accuracy (vertical axis) and speed (horizontal axis) of each alternatives. Up and to the right is better. The red square shows the initial program, and each blue circle shows an alternative.The line shows the best available speed-accuracy tradeoffs.

Initial Program: 52.8% accurate, 1.0× speedup?

\[\begin{array}{l} \\ \log \left(\frac{\sinh x}{x}\right) \end{array} \]
(FPCore (x) :precision binary64 (log (/ (sinh x) x)))
double code(double x) {
	return log((sinh(x) / x));
}
real(8) function code(x)
    real(8), intent (in) :: x
    code = log((sinh(x) / x))
end function
public static double code(double x) {
	return Math.log((Math.sinh(x) / x));
}
def code(x):
	return math.log((math.sinh(x) / x))
function code(x)
	return log(Float64(sinh(x) / x))
end
function tmp = code(x)
	tmp = log((sinh(x) / x));
end
code[x_] := N[Log[N[(N[Sinh[x], $MachinePrecision] / x), $MachinePrecision]], $MachinePrecision]
\begin{array}{l}

\\
\log \left(\frac{\sinh x}{x}\right)
\end{array}

Alternative 1: 97.2% accurate, 6.4× speedup?

\[\begin{array}{l} \\ \mathsf{fma}\left(\mathsf{fma}\left(x \cdot x, 0.0003527336860670194, -0.005555555555555556\right), x \cdot x, 0.16666666666666666\right) \cdot \left(x \cdot x\right) \end{array} \]
(FPCore (x)
 :precision binary64
 (*
  (fma
   (fma (* x x) 0.0003527336860670194 -0.005555555555555556)
   (* x x)
   0.16666666666666666)
  (* x x)))
double code(double x) {
	return fma(fma((x * x), 0.0003527336860670194, -0.005555555555555556), (x * x), 0.16666666666666666) * (x * x);
}
function code(x)
	return Float64(fma(fma(Float64(x * x), 0.0003527336860670194, -0.005555555555555556), Float64(x * x), 0.16666666666666666) * Float64(x * x))
end
code[x_] := N[(N[(N[(N[(x * x), $MachinePrecision] * 0.0003527336860670194 + -0.005555555555555556), $MachinePrecision] * N[(x * x), $MachinePrecision] + 0.16666666666666666), $MachinePrecision] * N[(x * x), $MachinePrecision]), $MachinePrecision]
\begin{array}{l}

\\
\mathsf{fma}\left(\mathsf{fma}\left(x \cdot x, 0.0003527336860670194, -0.005555555555555556\right), x \cdot x, 0.16666666666666666\right) \cdot \left(x \cdot x\right)
\end{array}
Derivation
  1. Initial program 53.6%

    \[\log \left(\frac{\sinh x}{x}\right) \]
  2. Add Preprocessing
  3. Taylor expanded in x around 0

    \[\leadsto \color{blue}{{x}^{2} \cdot \left(\frac{1}{6} + {x}^{2} \cdot \left({x}^{2} \cdot \left(\frac{1}{2835} + \frac{-1}{37800} \cdot {x}^{2}\right) - \frac{1}{180}\right)\right)} \]
  4. Step-by-step derivation
    1. *-commutativeN/A

      \[\leadsto \color{blue}{\left(\frac{1}{6} + {x}^{2} \cdot \left({x}^{2} \cdot \left(\frac{1}{2835} + \frac{-1}{37800} \cdot {x}^{2}\right) - \frac{1}{180}\right)\right) \cdot {x}^{2}} \]
    2. lower-*.f64N/A

      \[\leadsto \color{blue}{\left(\frac{1}{6} + {x}^{2} \cdot \left({x}^{2} \cdot \left(\frac{1}{2835} + \frac{-1}{37800} \cdot {x}^{2}\right) - \frac{1}{180}\right)\right) \cdot {x}^{2}} \]
  5. Applied rewrites98.2%

    \[\leadsto \color{blue}{\mathsf{fma}\left(\mathsf{fma}\left({x}^{4}, -2.6455026455026456 \cdot 10^{-5}, 0.0003527336860670194 \cdot \left(x \cdot x\right) - 0.005555555555555556\right), x \cdot x, 0.16666666666666666\right) \cdot \left(x \cdot x\right)} \]
  6. Taylor expanded in x around 0

    \[\leadsto \mathsf{fma}\left(\frac{1}{2835} \cdot {x}^{2} - \frac{1}{180}, x \cdot x, \frac{1}{6}\right) \cdot \left(x \cdot x\right) \]
  7. Step-by-step derivation
    1. Applied rewrites98.3%

      \[\leadsto \mathsf{fma}\left(\mathsf{fma}\left(x \cdot x, 0.0003527336860670194, -0.005555555555555556\right), x \cdot x, 0.16666666666666666\right) \cdot \left(x \cdot x\right) \]
    2. Add Preprocessing

    Alternative 2: 96.8% accurate, 9.6× speedup?

    \[\begin{array}{l} \\ \mathsf{fma}\left(-0.005555555555555556, x \cdot x, 0.16666666666666666\right) \cdot \left(x \cdot x\right) \end{array} \]
    (FPCore (x)
     :precision binary64
     (* (fma -0.005555555555555556 (* x x) 0.16666666666666666) (* x x)))
    double code(double x) {
    	return fma(-0.005555555555555556, (x * x), 0.16666666666666666) * (x * x);
    }
    
    function code(x)
    	return Float64(fma(-0.005555555555555556, Float64(x * x), 0.16666666666666666) * Float64(x * x))
    end
    
    code[x_] := N[(N[(-0.005555555555555556 * N[(x * x), $MachinePrecision] + 0.16666666666666666), $MachinePrecision] * N[(x * x), $MachinePrecision]), $MachinePrecision]
    
    \begin{array}{l}
    
    \\
    \mathsf{fma}\left(-0.005555555555555556, x \cdot x, 0.16666666666666666\right) \cdot \left(x \cdot x\right)
    \end{array}
    
    Derivation
    1. Initial program 53.6%

      \[\log \left(\frac{\sinh x}{x}\right) \]
    2. Add Preprocessing
    3. Taylor expanded in x around 0

      \[\leadsto \color{blue}{{x}^{2} \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right)} \]
    4. Step-by-step derivation
      1. *-commutativeN/A

        \[\leadsto \color{blue}{\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot {x}^{2}} \]
      2. unpow2N/A

        \[\leadsto \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot \color{blue}{\left(x \cdot x\right)} \]
      3. associate-*r*N/A

        \[\leadsto \color{blue}{\left(\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot x\right) \cdot x} \]
      4. lower-*.f64N/A

        \[\leadsto \color{blue}{\left(\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot x\right) \cdot x} \]
      5. lower-*.f64N/A

        \[\leadsto \color{blue}{\left(\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot x\right)} \cdot x \]
      6. +-commutativeN/A

        \[\leadsto \left(\color{blue}{\left(\frac{-1}{180} \cdot {x}^{2} + \frac{1}{6}\right)} \cdot x\right) \cdot x \]
      7. lower-fma.f64N/A

        \[\leadsto \left(\color{blue}{\mathsf{fma}\left(\frac{-1}{180}, {x}^{2}, \frac{1}{6}\right)} \cdot x\right) \cdot x \]
      8. unpow2N/A

        \[\leadsto \left(\mathsf{fma}\left(\frac{-1}{180}, \color{blue}{x \cdot x}, \frac{1}{6}\right) \cdot x\right) \cdot x \]
      9. lower-*.f6498.1

        \[\leadsto \left(\mathsf{fma}\left(-0.005555555555555556, \color{blue}{x \cdot x}, 0.16666666666666666\right) \cdot x\right) \cdot x \]
    5. Applied rewrites98.1%

      \[\leadsto \color{blue}{\left(\mathsf{fma}\left(-0.005555555555555556, x \cdot x, 0.16666666666666666\right) \cdot x\right) \cdot x} \]
    6. Step-by-step derivation
      1. Applied rewrites98.1%

        \[\leadsto \mathsf{fma}\left(-0.005555555555555556, x \cdot x, 0.16666666666666666\right) \cdot \color{blue}{\left(x \cdot x\right)} \]
      2. Add Preprocessing

      Alternative 3: 96.9% accurate, 9.6× speedup?

      \[\begin{array}{l} \\ \left(\mathsf{fma}\left(-0.005555555555555556, x \cdot x, 0.16666666666666666\right) \cdot x\right) \cdot x \end{array} \]
      (FPCore (x)
       :precision binary64
       (* (* (fma -0.005555555555555556 (* x x) 0.16666666666666666) x) x))
      double code(double x) {
      	return (fma(-0.005555555555555556, (x * x), 0.16666666666666666) * x) * x;
      }
      
      function code(x)
      	return Float64(Float64(fma(-0.005555555555555556, Float64(x * x), 0.16666666666666666) * x) * x)
      end
      
      code[x_] := N[(N[(N[(-0.005555555555555556 * N[(x * x), $MachinePrecision] + 0.16666666666666666), $MachinePrecision] * x), $MachinePrecision] * x), $MachinePrecision]
      
      \begin{array}{l}
      
      \\
      \left(\mathsf{fma}\left(-0.005555555555555556, x \cdot x, 0.16666666666666666\right) \cdot x\right) \cdot x
      \end{array}
      
      Derivation
      1. Initial program 53.6%

        \[\log \left(\frac{\sinh x}{x}\right) \]
      2. Add Preprocessing
      3. Taylor expanded in x around 0

        \[\leadsto \color{blue}{{x}^{2} \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right)} \]
      4. Step-by-step derivation
        1. *-commutativeN/A

          \[\leadsto \color{blue}{\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot {x}^{2}} \]
        2. unpow2N/A

          \[\leadsto \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot \color{blue}{\left(x \cdot x\right)} \]
        3. associate-*r*N/A

          \[\leadsto \color{blue}{\left(\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot x\right) \cdot x} \]
        4. lower-*.f64N/A

          \[\leadsto \color{blue}{\left(\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot x\right) \cdot x} \]
        5. lower-*.f64N/A

          \[\leadsto \color{blue}{\left(\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot x\right)} \cdot x \]
        6. +-commutativeN/A

          \[\leadsto \left(\color{blue}{\left(\frac{-1}{180} \cdot {x}^{2} + \frac{1}{6}\right)} \cdot x\right) \cdot x \]
        7. lower-fma.f64N/A

          \[\leadsto \left(\color{blue}{\mathsf{fma}\left(\frac{-1}{180}, {x}^{2}, \frac{1}{6}\right)} \cdot x\right) \cdot x \]
        8. unpow2N/A

          \[\leadsto \left(\mathsf{fma}\left(\frac{-1}{180}, \color{blue}{x \cdot x}, \frac{1}{6}\right) \cdot x\right) \cdot x \]
        9. lower-*.f6498.1

          \[\leadsto \left(\mathsf{fma}\left(-0.005555555555555556, \color{blue}{x \cdot x}, 0.16666666666666666\right) \cdot x\right) \cdot x \]
      5. Applied rewrites98.1%

        \[\leadsto \color{blue}{\left(\mathsf{fma}\left(-0.005555555555555556, x \cdot x, 0.16666666666666666\right) \cdot x\right) \cdot x} \]
      6. Add Preprocessing

      Alternative 4: 96.7% accurate, 19.3× speedup?

      \[\begin{array}{l} \\ \left(x \cdot x\right) \cdot 0.16666666666666666 \end{array} \]
      (FPCore (x) :precision binary64 (* (* x x) 0.16666666666666666))
      double code(double x) {
      	return (x * x) * 0.16666666666666666;
      }
      
      real(8) function code(x)
          real(8), intent (in) :: x
          code = (x * x) * 0.16666666666666666d0
      end function
      
      public static double code(double x) {
      	return (x * x) * 0.16666666666666666;
      }
      
      def code(x):
      	return (x * x) * 0.16666666666666666
      
      function code(x)
      	return Float64(Float64(x * x) * 0.16666666666666666)
      end
      
      function tmp = code(x)
      	tmp = (x * x) * 0.16666666666666666;
      end
      
      code[x_] := N[(N[(x * x), $MachinePrecision] * 0.16666666666666666), $MachinePrecision]
      
      \begin{array}{l}
      
      \\
      \left(x \cdot x\right) \cdot 0.16666666666666666
      \end{array}
      
      Derivation
      1. Initial program 53.6%

        \[\log \left(\frac{\sinh x}{x}\right) \]
      2. Add Preprocessing
      3. Taylor expanded in x around 0

        \[\leadsto \color{blue}{\frac{1}{6} \cdot {x}^{2}} \]
      4. Step-by-step derivation
        1. *-commutativeN/A

          \[\leadsto \color{blue}{{x}^{2} \cdot \frac{1}{6}} \]
        2. lower-*.f64N/A

          \[\leadsto \color{blue}{{x}^{2} \cdot \frac{1}{6}} \]
        3. unpow2N/A

          \[\leadsto \color{blue}{\left(x \cdot x\right)} \cdot \frac{1}{6} \]
        4. lower-*.f6498.1

          \[\leadsto \color{blue}{\left(x \cdot x\right)} \cdot 0.16666666666666666 \]
      5. Applied rewrites98.1%

        \[\leadsto \color{blue}{\left(x \cdot x\right) \cdot 0.16666666666666666} \]
      6. Add Preprocessing

      Developer Target 1: 97.9% accurate, 1.0× speedup?

      \[\begin{array}{l} \\ \begin{array}{l} \mathbf{if}\;\left|x\right| < 0.085:\\ \;\;\;\;\left(x \cdot x\right) \cdot \mathsf{fma}\left(\mathsf{fma}\left(\mathsf{fma}\left(-2.6455026455026456 \cdot 10^{-5}, x \cdot x, 0.0003527336860670194\right), x \cdot x, -0.005555555555555556\right), x \cdot x, 0.16666666666666666\right)\\ \mathbf{else}:\\ \;\;\;\;\log \left(\frac{\sinh x}{x}\right)\\ \end{array} \end{array} \]
      (FPCore (x)
       :precision binary64
       (if (< (fabs x) 0.085)
         (*
          (* x x)
          (fma
           (fma
            (fma -2.6455026455026456e-5 (* x x) 0.0003527336860670194)
            (* x x)
            -0.005555555555555556)
           (* x x)
           0.16666666666666666))
         (log (/ (sinh x) x))))
      double code(double x) {
      	double tmp;
      	if (fabs(x) < 0.085) {
      		tmp = (x * x) * fma(fma(fma(-2.6455026455026456e-5, (x * x), 0.0003527336860670194), (x * x), -0.005555555555555556), (x * x), 0.16666666666666666);
      	} else {
      		tmp = log((sinh(x) / x));
      	}
      	return tmp;
      }
      
      function code(x)
      	tmp = 0.0
      	if (abs(x) < 0.085)
      		tmp = Float64(Float64(x * x) * fma(fma(fma(-2.6455026455026456e-5, Float64(x * x), 0.0003527336860670194), Float64(x * x), -0.005555555555555556), Float64(x * x), 0.16666666666666666));
      	else
      		tmp = log(Float64(sinh(x) / x));
      	end
      	return tmp
      end
      
      code[x_] := If[Less[N[Abs[x], $MachinePrecision], 0.085], N[(N[(x * x), $MachinePrecision] * N[(N[(N[(-2.6455026455026456e-5 * N[(x * x), $MachinePrecision] + 0.0003527336860670194), $MachinePrecision] * N[(x * x), $MachinePrecision] + -0.005555555555555556), $MachinePrecision] * N[(x * x), $MachinePrecision] + 0.16666666666666666), $MachinePrecision]), $MachinePrecision], N[Log[N[(N[Sinh[x], $MachinePrecision] / x), $MachinePrecision]], $MachinePrecision]]
      
      \begin{array}{l}
      
      \\
      \begin{array}{l}
      \mathbf{if}\;\left|x\right| < 0.085:\\
      \;\;\;\;\left(x \cdot x\right) \cdot \mathsf{fma}\left(\mathsf{fma}\left(\mathsf{fma}\left(-2.6455026455026456 \cdot 10^{-5}, x \cdot x, 0.0003527336860670194\right), x \cdot x, -0.005555555555555556\right), x \cdot x, 0.16666666666666666\right)\\
      
      \mathbf{else}:\\
      \;\;\;\;\log \left(\frac{\sinh x}{x}\right)\\
      
      
      \end{array}
      \end{array}
      

      Reproduce

      ?
      herbie shell --seed 2024326 
      (FPCore (x)
        :name "bug500, discussion (missed optimization)"
        :precision binary64
      
        :alt
        (! :herbie-platform default (if (< (fabs x) 17/200) (let ((x2 (* x x))) (* x2 (fma (fma (fma -1/37800 x2 1/2835) x2 -1/180) x2 1/6))) (log (/ (sinh x) x))))
      
        (log (/ (sinh x) x)))