bug500 (missed optimization)

Percentage Accurate: 70.2% → 99.0%
Time: 7.5s
Alternatives: 8
Speedup: 6.5×

Specification

?
\[-1000 < x \land x < 1000\]
\[\begin{array}{l} \\ \sin x - x \end{array} \]
(FPCore (x) :precision binary64 (- (sin x) x))
double code(double x) {
	return sin(x) - x;
}
real(8) function code(x)
    real(8), intent (in) :: x
    code = sin(x) - x
end function
public static double code(double x) {
	return Math.sin(x) - x;
}
def code(x):
	return math.sin(x) - x
function code(x)
	return Float64(sin(x) - x)
end
function tmp = code(x)
	tmp = sin(x) - x;
end
code[x_] := N[(N[Sin[x], $MachinePrecision] - x), $MachinePrecision]
\begin{array}{l}

\\
\sin x - x
\end{array}

Sampling outcomes in binary64 precision:

Local Percentage Accuracy vs ?

The average percentage accuracy by input value. Horizontal axis shows value of an input variable; the variable is choosen in the title. Vertical axis is accuracy; higher is better. Red represent the original program, while blue represents Herbie's suggestion. These can be toggled with buttons below the plot. The line is an average while dots represent individual samples.

Accuracy vs Speed?

Herbie found 8 alternatives:

AlternativeAccuracySpeedup
The accuracy (vertical axis) and speed (horizontal axis) of each alternatives. Up and to the right is better. The red square shows the initial program, and each blue circle shows an alternative.The line shows the best available speed-accuracy tradeoffs.

Initial Program: 70.2% accurate, 1.0× speedup?

\[\begin{array}{l} \\ \sin x - x \end{array} \]
(FPCore (x) :precision binary64 (- (sin x) x))
double code(double x) {
	return sin(x) - x;
}
real(8) function code(x)
    real(8), intent (in) :: x
    code = sin(x) - x
end function
public static double code(double x) {
	return Math.sin(x) - x;
}
def code(x):
	return math.sin(x) - x
function code(x)
	return Float64(sin(x) - x)
end
function tmp = code(x)
	tmp = sin(x) - x;
end
code[x_] := N[(N[Sin[x], $MachinePrecision] - x), $MachinePrecision]
\begin{array}{l}

\\
\sin x - x
\end{array}

Alternative 1: 99.0% accurate, 0.7× speedup?

\[\begin{array}{l} \\ {x}^{3} \cdot \mathsf{fma}\left(x \cdot x, \mathsf{fma}\left(x, x \cdot \mathsf{fma}\left(x, x \cdot 2.7557319223985893 \cdot 10^{-6}, -0.0001984126984126984\right), 0.008333333333333333\right), -0.16666666666666666\right) \end{array} \]
(FPCore (x)
 :precision binary64
 (*
  (pow x 3.0)
  (fma
   (* x x)
   (fma
    x
    (* x (fma x (* x 2.7557319223985893e-6) -0.0001984126984126984))
    0.008333333333333333)
   -0.16666666666666666)))
double code(double x) {
	return pow(x, 3.0) * fma((x * x), fma(x, (x * fma(x, (x * 2.7557319223985893e-6), -0.0001984126984126984)), 0.008333333333333333), -0.16666666666666666);
}
function code(x)
	return Float64((x ^ 3.0) * fma(Float64(x * x), fma(x, Float64(x * fma(x, Float64(x * 2.7557319223985893e-6), -0.0001984126984126984)), 0.008333333333333333), -0.16666666666666666))
end
code[x_] := N[(N[Power[x, 3.0], $MachinePrecision] * N[(N[(x * x), $MachinePrecision] * N[(x * N[(x * N[(x * N[(x * 2.7557319223985893e-6), $MachinePrecision] + -0.0001984126984126984), $MachinePrecision]), $MachinePrecision] + 0.008333333333333333), $MachinePrecision] + -0.16666666666666666), $MachinePrecision]), $MachinePrecision]
\begin{array}{l}

\\
{x}^{3} \cdot \mathsf{fma}\left(x \cdot x, \mathsf{fma}\left(x, x \cdot \mathsf{fma}\left(x, x \cdot 2.7557319223985893 \cdot 10^{-6}, -0.0001984126984126984\right), 0.008333333333333333\right), -0.16666666666666666\right)
\end{array}
Derivation
  1. Initial program 68.5%

    \[\sin x - x \]
  2. Add Preprocessing
  3. Taylor expanded in x around 0

    \[\leadsto \color{blue}{{x}^{3} \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right)} \]
  4. Step-by-step derivation
    1. lower-*.f64N/A

      \[\leadsto \color{blue}{{x}^{3} \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right)} \]
    2. cube-multN/A

      \[\leadsto \color{blue}{\left(x \cdot \left(x \cdot x\right)\right)} \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right) \]
    3. unpow2N/A

      \[\leadsto \left(x \cdot \color{blue}{{x}^{2}}\right) \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right) \]
    4. lower-*.f64N/A

      \[\leadsto \color{blue}{\left(x \cdot {x}^{2}\right)} \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right) \]
    5. unpow2N/A

      \[\leadsto \left(x \cdot \color{blue}{\left(x \cdot x\right)}\right) \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right) \]
    6. lower-*.f64N/A

      \[\leadsto \left(x \cdot \color{blue}{\left(x \cdot x\right)}\right) \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right) \]
    7. sub-negN/A

      \[\leadsto \left(x \cdot \left(x \cdot x\right)\right) \cdot \color{blue}{\left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) + \left(\mathsf{neg}\left(\frac{1}{6}\right)\right)\right)} \]
    8. metadata-evalN/A

      \[\leadsto \left(x \cdot \left(x \cdot x\right)\right) \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) + \color{blue}{\frac{-1}{6}}\right) \]
    9. lower-fma.f64N/A

      \[\leadsto \left(x \cdot \left(x \cdot x\right)\right) \cdot \color{blue}{\mathsf{fma}\left({x}^{2}, \frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right), \frac{-1}{6}\right)} \]
  5. Applied rewrites98.3%

    \[\leadsto \color{blue}{\left(x \cdot \left(x \cdot x\right)\right) \cdot \mathsf{fma}\left(x \cdot x, \mathsf{fma}\left(x, x \cdot \mathsf{fma}\left(x, x \cdot 2.7557319223985893 \cdot 10^{-6}, -0.0001984126984126984\right), 0.008333333333333333\right), -0.16666666666666666\right)} \]
  6. Step-by-step derivation
    1. Applied rewrites98.3%

      \[\leadsto {x}^{3} \cdot \mathsf{fma}\left(\color{blue}{x \cdot x}, \mathsf{fma}\left(x, x \cdot \mathsf{fma}\left(x, x \cdot 2.7557319223985893 \cdot 10^{-6}, -0.0001984126984126984\right), 0.008333333333333333\right), -0.16666666666666666\right) \]
    2. Add Preprocessing

    Alternative 2: 98.9% accurate, 1.6× speedup?

    \[\begin{array}{l} \\ \mathsf{fma}\left(\left(x \cdot x\right) \cdot \left(\left(x \cdot x\right) \cdot \mathsf{fma}\left(x, x \cdot \mathsf{fma}\left(x \cdot x, 2.7557319223985893 \cdot 10^{-6}, -0.0001984126984126984\right), 0.008333333333333333\right)\right), x, -0.16666666666666666 \cdot \left(x \cdot \left(x \cdot x\right)\right)\right) \end{array} \]
    (FPCore (x)
     :precision binary64
     (fma
      (*
       (* x x)
       (*
        (* x x)
        (fma
         x
         (* x (fma (* x x) 2.7557319223985893e-6 -0.0001984126984126984))
         0.008333333333333333)))
      x
      (* -0.16666666666666666 (* x (* x x)))))
    double code(double x) {
    	return fma(((x * x) * ((x * x) * fma(x, (x * fma((x * x), 2.7557319223985893e-6, -0.0001984126984126984)), 0.008333333333333333))), x, (-0.16666666666666666 * (x * (x * x))));
    }
    
    function code(x)
    	return fma(Float64(Float64(x * x) * Float64(Float64(x * x) * fma(x, Float64(x * fma(Float64(x * x), 2.7557319223985893e-6, -0.0001984126984126984)), 0.008333333333333333))), x, Float64(-0.16666666666666666 * Float64(x * Float64(x * x))))
    end
    
    code[x_] := N[(N[(N[(x * x), $MachinePrecision] * N[(N[(x * x), $MachinePrecision] * N[(x * N[(x * N[(N[(x * x), $MachinePrecision] * 2.7557319223985893e-6 + -0.0001984126984126984), $MachinePrecision]), $MachinePrecision] + 0.008333333333333333), $MachinePrecision]), $MachinePrecision]), $MachinePrecision] * x + N[(-0.16666666666666666 * N[(x * N[(x * x), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]
    
    \begin{array}{l}
    
    \\
    \mathsf{fma}\left(\left(x \cdot x\right) \cdot \left(\left(x \cdot x\right) \cdot \mathsf{fma}\left(x, x \cdot \mathsf{fma}\left(x \cdot x, 2.7557319223985893 \cdot 10^{-6}, -0.0001984126984126984\right), 0.008333333333333333\right)\right), x, -0.16666666666666666 \cdot \left(x \cdot \left(x \cdot x\right)\right)\right)
    \end{array}
    
    Derivation
    1. Initial program 70.2%

      \[\sin x - x \]
    2. Add Preprocessing
    3. Taylor expanded in x around 0

      \[\leadsto \color{blue}{{x}^{3} \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right)} \]
    4. Step-by-step derivation
      1. lower-*.f64N/A

        \[\leadsto \color{blue}{{x}^{3} \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right)} \]
      2. cube-multN/A

        \[\leadsto \color{blue}{\left(x \cdot \left(x \cdot x\right)\right)} \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right) \]
      3. unpow2N/A

        \[\leadsto \left(x \cdot \color{blue}{{x}^{2}}\right) \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right) \]
      4. lower-*.f64N/A

        \[\leadsto \color{blue}{\left(x \cdot {x}^{2}\right)} \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right) \]
      5. unpow2N/A

        \[\leadsto \left(x \cdot \color{blue}{\left(x \cdot x\right)}\right) \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right) \]
      6. lower-*.f64N/A

        \[\leadsto \left(x \cdot \color{blue}{\left(x \cdot x\right)}\right) \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) - \frac{1}{6}\right) \]
      7. sub-negN/A

        \[\leadsto \left(x \cdot \left(x \cdot x\right)\right) \cdot \color{blue}{\left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) + \left(\mathsf{neg}\left(\frac{1}{6}\right)\right)\right)} \]
      8. metadata-evalN/A

        \[\leadsto \left(x \cdot \left(x \cdot x\right)\right) \cdot \left({x}^{2} \cdot \left(\frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right)\right) + \color{blue}{\frac{-1}{6}}\right) \]
      9. lower-fma.f64N/A

        \[\leadsto \left(x \cdot \left(x \cdot x\right)\right) \cdot \color{blue}{\mathsf{fma}\left({x}^{2}, \frac{1}{120} + {x}^{2} \cdot \left(\frac{1}{362880} \cdot {x}^{2} - \frac{1}{5040}\right), \frac{-1}{6}\right)} \]
    5. Applied rewrites98.9%

      \[\leadsto \color{blue}{\left(x \cdot \left(x \cdot x\right)\right) \cdot \mathsf{fma}\left(x \cdot x, \mathsf{fma}\left(x, x \cdot \mathsf{fma}\left(x, x \cdot 2.7557319223985893 \cdot 10^{-6}, -0.0001984126984126984\right), 0.008333333333333333\right), -0.16666666666666666\right)} \]
    6. Step-by-step derivation
      1. Applied rewrites98.9%

        \[\leadsto \mathsf{fma}\left(\left(\left(x \cdot x\right) \cdot \mathsf{fma}\left(x, x \cdot \mathsf{fma}\left(x \cdot x, 2.7557319223985893 \cdot 10^{-6}, -0.0001984126984126984\right), 0.008333333333333333\right)\right) \cdot \left(x \cdot x\right), \color{blue}{x}, \left(x \cdot \left(x \cdot x\right)\right) \cdot -0.16666666666666666\right) \]
      2. Final simplification98.9%

        \[\leadsto \mathsf{fma}\left(\left(x \cdot x\right) \cdot \left(\left(x \cdot x\right) \cdot \mathsf{fma}\left(x, x \cdot \mathsf{fma}\left(x \cdot x, 2.7557319223985893 \cdot 10^{-6}, -0.0001984126984126984\right), 0.008333333333333333\right)\right), x, -0.16666666666666666 \cdot \left(x \cdot \left(x \cdot x\right)\right)\right) \]
      3. Add Preprocessing

      Developer Target 1: 99.8% accurate, 0.3× speedup?

      \[\begin{array}{l} \\ \begin{array}{l} \mathbf{if}\;\left|x\right| < 0.07:\\ \;\;\;\;-\left(\left(\frac{{x}^{3}}{6} - \frac{{x}^{5}}{120}\right) + \frac{{x}^{7}}{5040}\right)\\ \mathbf{else}:\\ \;\;\;\;\sin x - x\\ \end{array} \end{array} \]
      (FPCore (x)
       :precision binary64
       (if (< (fabs x) 0.07)
         (- (+ (- (/ (pow x 3.0) 6.0) (/ (pow x 5.0) 120.0)) (/ (pow x 7.0) 5040.0)))
         (- (sin x) x)))
      double code(double x) {
      	double tmp;
      	if (fabs(x) < 0.07) {
      		tmp = -(((pow(x, 3.0) / 6.0) - (pow(x, 5.0) / 120.0)) + (pow(x, 7.0) / 5040.0));
      	} else {
      		tmp = sin(x) - x;
      	}
      	return tmp;
      }
      
      real(8) function code(x)
          real(8), intent (in) :: x
          real(8) :: tmp
          if (abs(x) < 0.07d0) then
              tmp = -((((x ** 3.0d0) / 6.0d0) - ((x ** 5.0d0) / 120.0d0)) + ((x ** 7.0d0) / 5040.0d0))
          else
              tmp = sin(x) - x
          end if
          code = tmp
      end function
      
      public static double code(double x) {
      	double tmp;
      	if (Math.abs(x) < 0.07) {
      		tmp = -(((Math.pow(x, 3.0) / 6.0) - (Math.pow(x, 5.0) / 120.0)) + (Math.pow(x, 7.0) / 5040.0));
      	} else {
      		tmp = Math.sin(x) - x;
      	}
      	return tmp;
      }
      
      def code(x):
      	tmp = 0
      	if math.fabs(x) < 0.07:
      		tmp = -(((math.pow(x, 3.0) / 6.0) - (math.pow(x, 5.0) / 120.0)) + (math.pow(x, 7.0) / 5040.0))
      	else:
      		tmp = math.sin(x) - x
      	return tmp
      
      function code(x)
      	tmp = 0.0
      	if (abs(x) < 0.07)
      		tmp = Float64(-Float64(Float64(Float64((x ^ 3.0) / 6.0) - Float64((x ^ 5.0) / 120.0)) + Float64((x ^ 7.0) / 5040.0)));
      	else
      		tmp = Float64(sin(x) - x);
      	end
      	return tmp
      end
      
      function tmp_2 = code(x)
      	tmp = 0.0;
      	if (abs(x) < 0.07)
      		tmp = -((((x ^ 3.0) / 6.0) - ((x ^ 5.0) / 120.0)) + ((x ^ 7.0) / 5040.0));
      	else
      		tmp = sin(x) - x;
      	end
      	tmp_2 = tmp;
      end
      
      code[x_] := If[Less[N[Abs[x], $MachinePrecision], 0.07], (-N[(N[(N[(N[Power[x, 3.0], $MachinePrecision] / 6.0), $MachinePrecision] - N[(N[Power[x, 5.0], $MachinePrecision] / 120.0), $MachinePrecision]), $MachinePrecision] + N[(N[Power[x, 7.0], $MachinePrecision] / 5040.0), $MachinePrecision]), $MachinePrecision]), N[(N[Sin[x], $MachinePrecision] - x), $MachinePrecision]]
      
      \begin{array}{l}
      
      \\
      \begin{array}{l}
      \mathbf{if}\;\left|x\right| < 0.07:\\
      \;\;\;\;-\left(\left(\frac{{x}^{3}}{6} - \frac{{x}^{5}}{120}\right) + \frac{{x}^{7}}{5040}\right)\\
      
      \mathbf{else}:\\
      \;\;\;\;\sin x - x\\
      
      
      \end{array}
      \end{array}
      

      Reproduce

      ?
      herbie shell --seed 2024230 
      (FPCore (x)
        :name "bug500 (missed optimization)"
        :precision binary64
        :pre (and (< -1000.0 x) (< x 1000.0))
      
        :alt
        (! :herbie-platform default (if (< (fabs x) 7/100) (- (+ (- (/ (pow x 3) 6) (/ (pow x 5) 120)) (/ (pow x 7) 5040))) (- (sin x) x)))
      
        (- (sin x) x))