bug500, discussion (missed optimization)

Percentage Accurate: 52.9% → 96.9%
Time: 13.0s
Alternatives: 6
Speedup: 19.3×

Specification

?
\[\begin{array}{l} \\ \log \left(\frac{\sinh x}{x}\right) \end{array} \]
(FPCore (x) :precision binary64 (log (/ (sinh x) x)))
double code(double x) {
	return log((sinh(x) / x));
}
real(8) function code(x)
    real(8), intent (in) :: x
    code = log((sinh(x) / x))
end function
public static double code(double x) {
	return Math.log((Math.sinh(x) / x));
}
def code(x):
	return math.log((math.sinh(x) / x))
function code(x)
	return log(Float64(sinh(x) / x))
end
function tmp = code(x)
	tmp = log((sinh(x) / x));
end
code[x_] := N[Log[N[(N[Sinh[x], $MachinePrecision] / x), $MachinePrecision]], $MachinePrecision]
\begin{array}{l}

\\
\log \left(\frac{\sinh x}{x}\right)
\end{array}

Sampling outcomes in binary64 precision:

Local Percentage Accuracy vs ?

The average percentage accuracy by input value. Horizontal axis shows value of an input variable; the variable is choosen in the title. Vertical axis is accuracy; higher is better. Red represent the original program, while blue represents Herbie's suggestion. These can be toggled with buttons below the plot. The line is an average while dots represent individual samples.

Accuracy vs Speed?

Herbie found 6 alternatives:

AlternativeAccuracySpeedup
The accuracy (vertical axis) and speed (horizontal axis) of each alternatives. Up and to the right is better. The red square shows the initial program, and each blue circle shows an alternative.The line shows the best available speed-accuracy tradeoffs.

Initial Program: 52.9% accurate, 1.0× speedup?

\[\begin{array}{l} \\ \log \left(\frac{\sinh x}{x}\right) \end{array} \]
(FPCore (x) :precision binary64 (log (/ (sinh x) x)))
double code(double x) {
	return log((sinh(x) / x));
}
real(8) function code(x)
    real(8), intent (in) :: x
    code = log((sinh(x) / x))
end function
public static double code(double x) {
	return Math.log((Math.sinh(x) / x));
}
def code(x):
	return math.log((math.sinh(x) / x))
function code(x)
	return log(Float64(sinh(x) / x))
end
function tmp = code(x)
	tmp = log((sinh(x) / x));
end
code[x_] := N[Log[N[(N[Sinh[x], $MachinePrecision] / x), $MachinePrecision]], $MachinePrecision]
\begin{array}{l}

\\
\log \left(\frac{\sinh x}{x}\right)
\end{array}

Alternative 1: 96.9% accurate, 7.6× speedup?

\[\begin{array}{l} \\ x \cdot \frac{x}{\mathsf{fma}\left(x, x \cdot 0.2, 6\right)} \end{array} \]
(FPCore (x) :precision binary64 (* x (/ x (fma x (* x 0.2) 6.0))))
double code(double x) {
	return x * (x / fma(x, (x * 0.2), 6.0));
}
function code(x)
	return Float64(x * Float64(x / fma(x, Float64(x * 0.2), 6.0)))
end
code[x_] := N[(x * N[(x / N[(x * N[(x * 0.2), $MachinePrecision] + 6.0), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]
\begin{array}{l}

\\
x \cdot \frac{x}{\mathsf{fma}\left(x, x \cdot 0.2, 6\right)}
\end{array}
Derivation
  1. Initial program 53.8%

    \[\log \left(\frac{\sinh x}{x}\right) \]
  2. Add Preprocessing
  3. Taylor expanded in x around 0

    \[\leadsto \color{blue}{{x}^{2} \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right)} \]
  4. Step-by-step derivation
    1. unpow2N/A

      \[\leadsto \color{blue}{\left(x \cdot x\right)} \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \]
    2. associate-*l*N/A

      \[\leadsto \color{blue}{x \cdot \left(x \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right)\right)} \]
    3. *-commutativeN/A

      \[\leadsto x \cdot \color{blue}{\left(\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot x\right)} \]
    4. lower-*.f64N/A

      \[\leadsto \color{blue}{x \cdot \left(\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot x\right)} \]
    5. *-commutativeN/A

      \[\leadsto x \cdot \color{blue}{\left(x \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right)\right)} \]
    6. lower-*.f64N/A

      \[\leadsto x \cdot \color{blue}{\left(x \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right)\right)} \]
    7. +-commutativeN/A

      \[\leadsto x \cdot \left(x \cdot \color{blue}{\left(\frac{-1}{180} \cdot {x}^{2} + \frac{1}{6}\right)}\right) \]
    8. *-commutativeN/A

      \[\leadsto x \cdot \left(x \cdot \left(\color{blue}{{x}^{2} \cdot \frac{-1}{180}} + \frac{1}{6}\right)\right) \]
    9. lower-fma.f64N/A

      \[\leadsto x \cdot \left(x \cdot \color{blue}{\mathsf{fma}\left({x}^{2}, \frac{-1}{180}, \frac{1}{6}\right)}\right) \]
    10. unpow2N/A

      \[\leadsto x \cdot \left(x \cdot \mathsf{fma}\left(\color{blue}{x \cdot x}, \frac{-1}{180}, \frac{1}{6}\right)\right) \]
    11. lower-*.f6498.4

      \[\leadsto x \cdot \left(x \cdot \mathsf{fma}\left(\color{blue}{x \cdot x}, -0.005555555555555556, 0.16666666666666666\right)\right) \]
  5. Applied rewrites98.4%

    \[\leadsto \color{blue}{x \cdot \left(x \cdot \mathsf{fma}\left(x \cdot x, -0.005555555555555556, 0.16666666666666666\right)\right)} \]
  6. Step-by-step derivation
    1. Applied rewrites98.5%

      \[\leadsto \frac{x \cdot x}{\color{blue}{\frac{1}{\mathsf{fma}\left(x \cdot x, -0.005555555555555556, 0.16666666666666666\right)}}} \]
    2. Taylor expanded in x around 0

      \[\leadsto \frac{x \cdot x}{6 + \color{blue}{\frac{1}{5} \cdot {x}^{2}}} \]
    3. Step-by-step derivation
      1. Applied rewrites98.6%

        \[\leadsto \frac{x \cdot x}{\mathsf{fma}\left(x, \color{blue}{x \cdot 0.2}, 6\right)} \]
      2. Step-by-step derivation
        1. Applied rewrites98.7%

          \[\leadsto \frac{x}{\mathsf{fma}\left(x, x \cdot 0.2, 6\right)} \cdot \color{blue}{x} \]
        2. Final simplification98.7%

          \[\leadsto x \cdot \frac{x}{\mathsf{fma}\left(x, x \cdot 0.2, 6\right)} \]
        3. Add Preprocessing

        Alternative 2: 96.5% accurate, 7.9× speedup?

        \[\begin{array}{l} \\ x \cdot \mathsf{fma}\left(-0.005555555555555556 \cdot \left(x \cdot x\right), x, x \cdot 0.16666666666666666\right) \end{array} \]
        (FPCore (x)
         :precision binary64
         (* x (fma (* -0.005555555555555556 (* x x)) x (* x 0.16666666666666666))))
        double code(double x) {
        	return x * fma((-0.005555555555555556 * (x * x)), x, (x * 0.16666666666666666));
        }
        
        function code(x)
        	return Float64(x * fma(Float64(-0.005555555555555556 * Float64(x * x)), x, Float64(x * 0.16666666666666666)))
        end
        
        code[x_] := N[(x * N[(N[(-0.005555555555555556 * N[(x * x), $MachinePrecision]), $MachinePrecision] * x + N[(x * 0.16666666666666666), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]
        
        \begin{array}{l}
        
        \\
        x \cdot \mathsf{fma}\left(-0.005555555555555556 \cdot \left(x \cdot x\right), x, x \cdot 0.16666666666666666\right)
        \end{array}
        
        Derivation
        1. Initial program 52.9%

          \[\log \left(\frac{\sinh x}{x}\right) \]
        2. Add Preprocessing
        3. Taylor expanded in x around 0

          \[\leadsto \color{blue}{{x}^{2} \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right)} \]
        4. Step-by-step derivation
          1. unpow2N/A

            \[\leadsto \color{blue}{\left(x \cdot x\right)} \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \]
          2. associate-*l*N/A

            \[\leadsto \color{blue}{x \cdot \left(x \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right)\right)} \]
          3. *-commutativeN/A

            \[\leadsto x \cdot \color{blue}{\left(\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot x\right)} \]
          4. lower-*.f64N/A

            \[\leadsto \color{blue}{x \cdot \left(\left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right) \cdot x\right)} \]
          5. *-commutativeN/A

            \[\leadsto x \cdot \color{blue}{\left(x \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right)\right)} \]
          6. lower-*.f64N/A

            \[\leadsto x \cdot \color{blue}{\left(x \cdot \left(\frac{1}{6} + \frac{-1}{180} \cdot {x}^{2}\right)\right)} \]
          7. +-commutativeN/A

            \[\leadsto x \cdot \left(x \cdot \color{blue}{\left(\frac{-1}{180} \cdot {x}^{2} + \frac{1}{6}\right)}\right) \]
          8. *-commutativeN/A

            \[\leadsto x \cdot \left(x \cdot \left(\color{blue}{{x}^{2} \cdot \frac{-1}{180}} + \frac{1}{6}\right)\right) \]
          9. lower-fma.f64N/A

            \[\leadsto x \cdot \left(x \cdot \color{blue}{\mathsf{fma}\left({x}^{2}, \frac{-1}{180}, \frac{1}{6}\right)}\right) \]
          10. unpow2N/A

            \[\leadsto x \cdot \left(x \cdot \mathsf{fma}\left(\color{blue}{x \cdot x}, \frac{-1}{180}, \frac{1}{6}\right)\right) \]
          11. lower-*.f6496.5

            \[\leadsto x \cdot \left(x \cdot \mathsf{fma}\left(\color{blue}{x \cdot x}, -0.005555555555555556, 0.16666666666666666\right)\right) \]
        5. Applied rewrites96.5%

          \[\leadsto \color{blue}{x \cdot \left(x \cdot \mathsf{fma}\left(x \cdot x, -0.005555555555555556, 0.16666666666666666\right)\right)} \]
        6. Step-by-step derivation
          1. Applied rewrites96.5%

            \[\leadsto x \cdot \mathsf{fma}\left(\left(x \cdot x\right) \cdot -0.005555555555555556, \color{blue}{x}, x \cdot 0.16666666666666666\right) \]
          2. Final simplification96.5%

            \[\leadsto x \cdot \mathsf{fma}\left(-0.005555555555555556 \cdot \left(x \cdot x\right), x, x \cdot 0.16666666666666666\right) \]
          3. Add Preprocessing

          Developer Target 1: 97.7% accurate, 1.0× speedup?

          \[\begin{array}{l} \\ \begin{array}{l} \mathbf{if}\;\left|x\right| < 0.085:\\ \;\;\;\;\left(x \cdot x\right) \cdot \mathsf{fma}\left(\mathsf{fma}\left(\mathsf{fma}\left(-2.6455026455026456 \cdot 10^{-5}, x \cdot x, 0.0003527336860670194\right), x \cdot x, -0.005555555555555556\right), x \cdot x, 0.16666666666666666\right)\\ \mathbf{else}:\\ \;\;\;\;\log \left(\frac{\sinh x}{x}\right)\\ \end{array} \end{array} \]
          (FPCore (x)
           :precision binary64
           (if (< (fabs x) 0.085)
             (*
              (* x x)
              (fma
               (fma
                (fma -2.6455026455026456e-5 (* x x) 0.0003527336860670194)
                (* x x)
                -0.005555555555555556)
               (* x x)
               0.16666666666666666))
             (log (/ (sinh x) x))))
          double code(double x) {
          	double tmp;
          	if (fabs(x) < 0.085) {
          		tmp = (x * x) * fma(fma(fma(-2.6455026455026456e-5, (x * x), 0.0003527336860670194), (x * x), -0.005555555555555556), (x * x), 0.16666666666666666);
          	} else {
          		tmp = log((sinh(x) / x));
          	}
          	return tmp;
          }
          
          function code(x)
          	tmp = 0.0
          	if (abs(x) < 0.085)
          		tmp = Float64(Float64(x * x) * fma(fma(fma(-2.6455026455026456e-5, Float64(x * x), 0.0003527336860670194), Float64(x * x), -0.005555555555555556), Float64(x * x), 0.16666666666666666));
          	else
          		tmp = log(Float64(sinh(x) / x));
          	end
          	return tmp
          end
          
          code[x_] := If[Less[N[Abs[x], $MachinePrecision], 0.085], N[(N[(x * x), $MachinePrecision] * N[(N[(N[(-2.6455026455026456e-5 * N[(x * x), $MachinePrecision] + 0.0003527336860670194), $MachinePrecision] * N[(x * x), $MachinePrecision] + -0.005555555555555556), $MachinePrecision] * N[(x * x), $MachinePrecision] + 0.16666666666666666), $MachinePrecision]), $MachinePrecision], N[Log[N[(N[Sinh[x], $MachinePrecision] / x), $MachinePrecision]], $MachinePrecision]]
          
          \begin{array}{l}
          
          \\
          \begin{array}{l}
          \mathbf{if}\;\left|x\right| < 0.085:\\
          \;\;\;\;\left(x \cdot x\right) \cdot \mathsf{fma}\left(\mathsf{fma}\left(\mathsf{fma}\left(-2.6455026455026456 \cdot 10^{-5}, x \cdot x, 0.0003527336860670194\right), x \cdot x, -0.005555555555555556\right), x \cdot x, 0.16666666666666666\right)\\
          
          \mathbf{else}:\\
          \;\;\;\;\log \left(\frac{\sinh x}{x}\right)\\
          
          
          \end{array}
          \end{array}
          

          Reproduce

          ?
          herbie shell --seed 2024223 
          (FPCore (x)
            :name "bug500, discussion (missed optimization)"
            :precision binary64
          
            :alt
            (! :herbie-platform default (if (< (fabs x) 17/200) (let ((x2 (* x x))) (* x2 (fma (fma (fma -1/37800 x2 1/2835) x2 -1/180) x2 1/6))) (log (/ (sinh x) x))))
          
            (log (/ (sinh x) x)))