bug366 (missed optimization)

Percentage Accurate: 44.7% → 100.0%

Time: 4.8s

Alternatives: 2

Speedup: 32.0×

Specification

Math

\[\begin{array}{l} \\ \sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \end{array} \]

FPCore

(FPCore (x y z) :precision binary64 (sqrt (+ (* x x) (+ (* y y) (* z z)))))

C

double code(double x, double y, double z) {
	return sqrt(((x * x) + ((y * y) + (z * z))));
}

Fortran

real(8) function code(x, y, z)
    real(8), intent (in) :: x
    real(8), intent (in) :: y
    real(8), intent (in) :: z
    code = sqrt(((x * x) + ((y * y) + (z * z))))
end function

Java

public static double code(double x, double y, double z) {
	return Math.sqrt(((x * x) + ((y * y) + (z * z))));
}

Python

def code(x, y, z):
	return math.sqrt(((x * x) + ((y * y) + (z * z))))

Julia

function code(x, y, z)
	return sqrt(Float64(Float64(x * x) + Float64(Float64(y * y) + Float64(z * z))))
end

MATLAB

function tmp = code(x, y, z)
	tmp = sqrt(((x * x) + ((y * y) + (z * z))));
end

Wolfram

code[x_, y_, z_] := N[Sqrt[N[(N[(x * x), $MachinePrecision] + N[(N[(y * y), $MachinePrecision] + N[(z * z), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]], $MachinePrecision]

Initial Program: 44.7% accurate, 1.0× speedup

Math

\[\begin{array}{l} \\ \sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \end{array} \]

FPCore

(FPCore (x y z) :precision binary64 (sqrt (+ (* x x) (+ (* y y) (* z z)))))

C

double code(double x, double y, double z) {
	return sqrt(((x * x) + ((y * y) + (z * z))));
}

Fortran

real(8) function code(x, y, z)
    real(8), intent (in) :: x
    real(8), intent (in) :: y
    real(8), intent (in) :: z
    code = sqrt(((x * x) + ((y * y) + (z * z))))
end function

Java

public static double code(double x, double y, double z) {
	return Math.sqrt(((x * x) + ((y * y) + (z * z))));
}

Python

def code(x, y, z):
	return math.sqrt(((x * x) + ((y * y) + (z * z))))

Julia

function code(x, y, z)
	return sqrt(Float64(Float64(x * x) + Float64(Float64(y * y) + Float64(z * z))))
end

MATLAB

function tmp = code(x, y, z)
	tmp = sqrt(((x * x) + ((y * y) + (z * z))));
end

Wolfram

code[x_, y_, z_] := N[Sqrt[N[(N[(x * x), $MachinePrecision] + N[(N[(y * y), $MachinePrecision] + N[(z * z), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]], $MachinePrecision]

Alternative 1: 100.0% accurate, 0.3× speedup

Math

\[\begin{array}{l} z_m = \left|z\right| \\ y_m = \left|y\right| \\ x_m = \left|x\right| \\ [x_m, y_m, z_m] = \mathsf{sort}([x_m, y_m, z_m])\\ \\ \mathsf{hypot}\left(z\_m, y\_m\right) \end{array} \]

FPCore

z_m = (fabs.f64 z)
y_m = (fabs.f64 y)
x_m = (fabs.f64 x)
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
(FPCore (x_m y_m z_m) :precision binary64 (hypot z_m y_m))

C

z_m = fabs(z);
y_m = fabs(y);
x_m = fabs(x);
assert(x_m < y_m && y_m < z_m);
double code(double x_m, double y_m, double z_m) {
	return hypot(z_m, y_m);
}

Java

z_m = Math.abs(z);
y_m = Math.abs(y);
x_m = Math.abs(x);
assert x_m < y_m && y_m < z_m;
public static double code(double x_m, double y_m, double z_m) {
	return Math.hypot(z_m, y_m);
}

Python

z_m = math.fabs(z)
y_m = math.fabs(y)
x_m = math.fabs(x)
[x_m, y_m, z_m] = sort([x_m, y_m, z_m])
def code(x_m, y_m, z_m):
	return math.hypot(z_m, y_m)

Julia

z_m = abs(z)
y_m = abs(y)
x_m = abs(x)
x_m, y_m, z_m = sort([x_m, y_m, z_m])
function code(x_m, y_m, z_m)
	return hypot(z_m, y_m)
end

MATLAB

z_m = abs(z);
y_m = abs(y);
x_m = abs(x);
x_m, y_m, z_m = num2cell(sort([x_m, y_m, z_m])){:}
function tmp = code(x_m, y_m, z_m)
	tmp = hypot(z_m, y_m);
end

Wolfram

z_m = N[Abs[z], $MachinePrecision]
y_m = N[Abs[y], $MachinePrecision]
x_m = N[Abs[x], $MachinePrecision]
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
code[x$95$m_, y$95$m_, z$95$m_] := N[Sqrt[z$95$m ^ 2 + y$95$m ^ 2], $MachinePrecision]

Derivation

1. Initial program 43.8%

   \[\sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \]
2. Add Preprocessing

3. Taylor expanded in x around 0

   \[\leadsto \sqrt{\color{blue}{{y}^{2} + {z}^{2}}} \]
4. Step-by-step derivation

   1. +-commutative N/A

      \[\leadsto \sqrt{\color{blue}{{z}^{2} + {y}^{2}}} \]

   2. unpow2 N/A

      \[\leadsto \sqrt{\color{blue}{z \cdot z} + {y}^{2}} \]

   3. lower-fma.f64 N/A

      \[\leadsto \sqrt{\color{blue}{\mathsf{fma}\left(z, z, {y}^{2}\right)}} \]

   4. unpow2 N/A

      \[\leadsto \sqrt{\mathsf{fma}\left(z, z, \color{blue}{y \cdot y}\right)} \]

   5. lower-*.f64 34.3

      \[\leadsto \sqrt{\mathsf{fma}\left(z, z, \color{blue}{y \cdot y}\right)} \]

5. Applied rewrites 34.3%

   \[\leadsto \sqrt{\color{blue}{\mathsf{fma}\left(z, z, y \cdot y\right)}} \]
6. Step-by-step derivation

   1. lower-hypot.f64 73.9

      \[\leadsto \color{blue}{\mathsf{hypot}\left(z, y\right)} \]

7. Applied rewrites 73.9%

   \[\leadsto \color{blue}{\mathsf{hypot}\left(z, y\right)} \]
8. Add Preprocessing

Alternative 2: 98.5% accurate, 32.0× speedup

Math

\[\begin{array}{l} z_m = \left|z\right| \\ y_m = \left|y\right| \\ x_m = \left|x\right| \\ [x_m, y_m, z_m] = \mathsf{sort}([x_m, y_m, z_m])\\ \\ z\_m \end{array} \]

FPCore

z_m = (fabs.f64 z)
y_m = (fabs.f64 y)
x_m = (fabs.f64 x)
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
(FPCore (x_m y_m z_m) :precision binary64 z_m)

C

z_m = fabs(z);
y_m = fabs(y);
x_m = fabs(x);
assert(x_m < y_m && y_m < z_m);
double code(double x_m, double y_m, double z_m) {
	return z_m;
}

Fortran

z_m = abs(z)
y_m = abs(y)
x_m = abs(x)
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
real(8) function code(x_m, y_m, z_m)
    real(8), intent (in) :: x_m
    real(8), intent (in) :: y_m
    real(8), intent (in) :: z_m
    code = z_m
end function

Java

z_m = Math.abs(z);
y_m = Math.abs(y);
x_m = Math.abs(x);
assert x_m < y_m && y_m < z_m;
public static double code(double x_m, double y_m, double z_m) {
	return z_m;
}

Python

z_m = math.fabs(z)
y_m = math.fabs(y)
x_m = math.fabs(x)
[x_m, y_m, z_m] = sort([x_m, y_m, z_m])
def code(x_m, y_m, z_m):
	return z_m

Julia

z_m = abs(z)
y_m = abs(y)
x_m = abs(x)
x_m, y_m, z_m = sort([x_m, y_m, z_m])
function code(x_m, y_m, z_m)
	return z_m
end

MATLAB

z_m = abs(z);
y_m = abs(y);
x_m = abs(x);
x_m, y_m, z_m = num2cell(sort([x_m, y_m, z_m])){:}
function tmp = code(x_m, y_m, z_m)
	tmp = z_m;
end

Wolfram

z_m = N[Abs[z], $MachinePrecision]
y_m = N[Abs[y], $MachinePrecision]
x_m = N[Abs[x], $MachinePrecision]
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
code[x$95$m_, y$95$m_, z$95$m_] := z$95$m

Derivation

1. Initial program 43.8%

   \[\sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \]
2. Add Preprocessing

3. Taylor expanded in z around inf

   \[\leadsto \sqrt{\color{blue}{{z}^{2}}} \]
4. Step-by-step derivation

   1. unpow2 N/A

      \[\leadsto \sqrt{\color{blue}{z \cdot z}} \]

   2. lower-*.f64 20.2

      \[\leadsto \sqrt{\color{blue}{z \cdot z}} \]

5. Applied rewrites 20.2%

   \[\leadsto \sqrt{\color{blue}{z \cdot z}} \]
6. Step-by-step derivation

   1. sqrt-prod N/A

      \[\leadsto \color{blue}{\sqrt{z} \cdot \sqrt{z}} \]

   2. rem-square-sqrt 21.5

      \[\leadsto \color{blue}{z} \]

7. Applied rewrites 21.5%

   \[\leadsto \color{blue}{z} \]
8. Add Preprocessing

Developer Target 1: 100.0% accurate, 0.2× speedup

Math

\[\begin{array}{l} \\ \mathsf{hypot}\left(x, \mathsf{hypot}\left(y, z\right)\right) \end{array} \]

FPCore

(FPCore (x y z) :precision binary64 (hypot x (hypot y z)))

C

double code(double x, double y, double z) {
	return hypot(x, hypot(y, z));
}

Java

public static double code(double x, double y, double z) {
	return Math.hypot(x, Math.hypot(y, z));
}

Python

def code(x, y, z):
	return math.hypot(x, math.hypot(y, z))

Julia

function code(x, y, z)
	return hypot(x, hypot(y, z))
end

MATLAB

function tmp = code(x, y, z)
	tmp = hypot(x, hypot(y, z));
end

Wolfram

code[x_, y_, z_] := N[Sqrt[x ^ 2 + N[Sqrt[y ^ 2 + z ^ 2], $MachinePrecision] ^ 2], $MachinePrecision]

Reproduce

herbie shell --seed 2024216 
(FPCore (x y z)
  :name "bug366 (missed optimization)"
  :precision binary64

  :alt
  (! :herbie-platform default (hypot x (hypot y z)))

  (sqrt (+ (* x x) (+ (* y y) (* z z)))))