bug366 (missed optimization)

Percentage Accurate: 45.2% → 100.0%

Time: 2.9s

Alternatives: 2

Speedup: 111.0×

Specification

Math

\[\begin{array}{l} \\ \sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \end{array} \]

FPCore

(FPCore (x y z) :precision binary64 (sqrt (+ (* x x) (+ (* y y) (* z z)))))

C

double code(double x, double y, double z) {
	return sqrt(((x * x) + ((y * y) + (z * z))));
}

Fortran

real(8) function code(x, y, z)
    real(8), intent (in) :: x
    real(8), intent (in) :: y
    real(8), intent (in) :: z
    code = sqrt(((x * x) + ((y * y) + (z * z))))
end function

Java

public static double code(double x, double y, double z) {
	return Math.sqrt(((x * x) + ((y * y) + (z * z))));
}

Python

def code(x, y, z):
	return math.sqrt(((x * x) + ((y * y) + (z * z))))

Julia

function code(x, y, z)
	return sqrt(Float64(Float64(x * x) + Float64(Float64(y * y) + Float64(z * z))))
end

MATLAB

function tmp = code(x, y, z)
	tmp = sqrt(((x * x) + ((y * y) + (z * z))));
end

Wolfram

code[x_, y_, z_] := N[Sqrt[N[(N[(x * x), $MachinePrecision] + N[(N[(y * y), $MachinePrecision] + N[(z * z), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]], $MachinePrecision]

Initial Program: 45.2% accurate, 1.0× speedup

Math

\[\begin{array}{l} \\ \sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \end{array} \]

FPCore

(FPCore (x y z) :precision binary64 (sqrt (+ (* x x) (+ (* y y) (* z z)))))

C

double code(double x, double y, double z) {
	return sqrt(((x * x) + ((y * y) + (z * z))));
}

Fortran

real(8) function code(x, y, z)
    real(8), intent (in) :: x
    real(8), intent (in) :: y
    real(8), intent (in) :: z
    code = sqrt(((x * x) + ((y * y) + (z * z))))
end function

Java

public static double code(double x, double y, double z) {
	return Math.sqrt(((x * x) + ((y * y) + (z * z))));
}

Python

def code(x, y, z):
	return math.sqrt(((x * x) + ((y * y) + (z * z))))

Julia

function code(x, y, z)
	return sqrt(Float64(Float64(x * x) + Float64(Float64(y * y) + Float64(z * z))))
end

MATLAB

function tmp = code(x, y, z)
	tmp = sqrt(((x * x) + ((y * y) + (z * z))));
end

Wolfram

code[x_, y_, z_] := N[Sqrt[N[(N[(x * x), $MachinePrecision] + N[(N[(y * y), $MachinePrecision] + N[(z * z), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]], $MachinePrecision]

Alternative 1: 100.0% accurate, 1.1× speedup

Math

\[\begin{array}{l} x_m = \left|x\right| \\ y_m = \left|y\right| \\ z_m = \left|z\right| \\ [x_m, y_m, z_m] = \mathsf{sort}([x_m, y_m, z_m])\\ \\ \mathsf{hypot}\left(y\_m, z\_m\right) \end{array} \]

FPCore

x_m = (fabs.f64 x)
y_m = (fabs.f64 y)
z_m = (fabs.f64 z)
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
(FPCore (x_m y_m z_m) :precision binary64 (hypot y_m z_m))

C

x_m = fabs(x);
y_m = fabs(y);
z_m = fabs(z);
assert(x_m < y_m && y_m < z_m);
double code(double x_m, double y_m, double z_m) {
	return hypot(y_m, z_m);
}

Java

x_m = Math.abs(x);
y_m = Math.abs(y);
z_m = Math.abs(z);
assert x_m < y_m && y_m < z_m;
public static double code(double x_m, double y_m, double z_m) {
	return Math.hypot(y_m, z_m);
}

Python

x_m = math.fabs(x)
y_m = math.fabs(y)
z_m = math.fabs(z)
[x_m, y_m, z_m] = sort([x_m, y_m, z_m])
def code(x_m, y_m, z_m):
	return math.hypot(y_m, z_m)

Julia

x_m = abs(x)
y_m = abs(y)
z_m = abs(z)
x_m, y_m, z_m = sort([x_m, y_m, z_m])
function code(x_m, y_m, z_m)
	return hypot(y_m, z_m)
end

MATLAB

x_m = abs(x);
y_m = abs(y);
z_m = abs(z);
x_m, y_m, z_m = num2cell(sort([x_m, y_m, z_m])){:}
function tmp = code(x_m, y_m, z_m)
	tmp = hypot(y_m, z_m);
end

Wolfram

x_m = N[Abs[x], $MachinePrecision]
y_m = N[Abs[y], $MachinePrecision]
z_m = N[Abs[z], $MachinePrecision]
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
code[x$95$m_, y$95$m_, z$95$m_] := N[Sqrt[y$95$m ^ 2 + z$95$m ^ 2], $MachinePrecision]

Derivation

1. Initial program 47.8%

   \[\sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \]
2. Add Preprocessing

3. Taylor expanded in x around 0 33.9%

   \[\leadsto \color{blue}{\sqrt{{y}^{2} + {z}^{2}}} \]
4. Step-by-step derivation

   1. unpow2 33.9%

      \[\leadsto \sqrt{\color{blue}{y \cdot y} + {z}^{2}} \]

   2. unpow2 33.9%

      \[\leadsto \sqrt{y \cdot y + \color{blue}{z \cdot z}} \]

   3. hypot-undefine 68.8%

      \[\leadsto \color{blue}{\mathsf{hypot}\left(y, z\right)} \]

5. Simplified 68.8%

   \[\leadsto \color{blue}{\mathsf{hypot}\left(y, z\right)} \]
6. Add Preprocessing

Alternative 2: 98.7% accurate, 111.0× speedup

Math

\[\begin{array}{l} x_m = \left|x\right| \\ y_m = \left|y\right| \\ z_m = \left|z\right| \\ [x_m, y_m, z_m] = \mathsf{sort}([x_m, y_m, z_m])\\ \\ z\_m \end{array} \]

FPCore

x_m = (fabs.f64 x)
y_m = (fabs.f64 y)
z_m = (fabs.f64 z)
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
(FPCore (x_m y_m z_m) :precision binary64 z_m)

C

x_m = fabs(x);
y_m = fabs(y);
z_m = fabs(z);
assert(x_m < y_m && y_m < z_m);
double code(double x_m, double y_m, double z_m) {
	return z_m;
}

Fortran

x_m = abs(x)
y_m = abs(y)
z_m = abs(z)
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
real(8) function code(x_m, y_m, z_m)
    real(8), intent (in) :: x_m
    real(8), intent (in) :: y_m
    real(8), intent (in) :: z_m
    code = z_m
end function

Java

x_m = Math.abs(x);
y_m = Math.abs(y);
z_m = Math.abs(z);
assert x_m < y_m && y_m < z_m;
public static double code(double x_m, double y_m, double z_m) {
	return z_m;
}

Python

x_m = math.fabs(x)
y_m = math.fabs(y)
z_m = math.fabs(z)
[x_m, y_m, z_m] = sort([x_m, y_m, z_m])
def code(x_m, y_m, z_m):
	return z_m

Julia

x_m = abs(x)
y_m = abs(y)
z_m = abs(z)
x_m, y_m, z_m = sort([x_m, y_m, z_m])
function code(x_m, y_m, z_m)
	return z_m
end

MATLAB

x_m = abs(x);
y_m = abs(y);
z_m = abs(z);
x_m, y_m, z_m = num2cell(sort([x_m, y_m, z_m])){:}
function tmp = code(x_m, y_m, z_m)
	tmp = z_m;
end

Wolfram

x_m = N[Abs[x], $MachinePrecision]
y_m = N[Abs[y], $MachinePrecision]
z_m = N[Abs[z], $MachinePrecision]
NOTE: x_m, y_m, and z_m should be sorted in increasing order before calling this function.
code[x$95$m_, y$95$m_, z$95$m_] := z$95$m

Derivation

1. Initial program 47.8%

   \[\sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \]
2. Add Preprocessing

3. Taylor expanded in z around inf 17.9%

   \[\leadsto \color{blue}{z} \]
4. Add Preprocessing

Developer Target 1: 100.0% accurate, 0.5× speedup

Math

\[\begin{array}{l} \\ \mathsf{hypot}\left(x, \mathsf{hypot}\left(y, z\right)\right) \end{array} \]

FPCore

(FPCore (x y z) :precision binary64 (hypot x (hypot y z)))

C

double code(double x, double y, double z) {
	return hypot(x, hypot(y, z));
}

Java

public static double code(double x, double y, double z) {
	return Math.hypot(x, Math.hypot(y, z));
}

Python

def code(x, y, z):
	return math.hypot(x, math.hypot(y, z))

Julia

function code(x, y, z)
	return hypot(x, hypot(y, z))
end

MATLAB

function tmp = code(x, y, z)
	tmp = hypot(x, hypot(y, z));
end

Wolfram

code[x_, y_, z_] := N[Sqrt[x ^ 2 + N[Sqrt[y ^ 2 + z ^ 2], $MachinePrecision] ^ 2], $MachinePrecision]

Reproduce

herbie shell --seed 2024160 
(FPCore (x y z)
  :name "bug366 (missed optimization)"
  :precision binary64

  :alt
  (! :herbie-platform default (hypot x (hypot y z)))

  (sqrt (+ (* x x) (+ (* y y) (* z z)))))