bug333 (missed optimization)

?

Percentage Accurate: 6.1% → 100.0%
Time: 4.9s
Precision: binary64
Cost: 64

?

\[-1 \leq x \land x \leq 1\]
\[\sqrt{1 + x} - \sqrt{1 - x} \]
↓
\[x \]
(FPCore (x) :precision binary64 (- (sqrt (+ 1.0 x)) (sqrt (- 1.0 x))))
↓
(FPCore (x) :precision binary64 x)
double code(double x) {
	return sqrt((1.0 + x)) - sqrt((1.0 - x));
}
↓
double code(double x) {
	return x;
}

real(8) function code(x)
    real(8), intent (in) :: x
    code = sqrt((1.0d0 + x)) - sqrt((1.0d0 - x))
end function
↓
real(8) function code(x)
    real(8), intent (in) :: x
    code = x
end function

public static double code(double x) {
	return Math.sqrt((1.0 + x)) - Math.sqrt((1.0 - x));
}
↓
public static double code(double x) {
	return x;
}

def code(x):
	return math.sqrt((1.0 + x)) - math.sqrt((1.0 - x))
↓
def code(x):
	return x

function code(x)
	return Float64(sqrt(Float64(1.0 + x)) - sqrt(Float64(1.0 - x)))
end
↓
function code(x)
	return x
end

function tmp = code(x)
	tmp = sqrt((1.0 + x)) - sqrt((1.0 - x));
end
↓
function tmp = code(x)
	tmp = x;
end

code[x_] := N[(N[Sqrt[N[(1.0 + x), $MachinePrecision]], $MachinePrecision] - N[Sqrt[N[(1.0 - x), $MachinePrecision]], $MachinePrecision]), $MachinePrecision]
↓
code[x_] := x

\sqrt{1 + x} - \sqrt{1 - x}
↓
x

Local Percentage Accuracy vs ?

The average percentage accuracy by input value. Horizontal axis shows value of an input variable; the variable is choosen in the title. Vertical axis is accuracy; higher is better. Red represent the original program, while blue represents Herbie's suggestion. These can be toggled with buttons below the plot. The line is an average while dots represent individual samples.

Herbie found 1 alternatives:

AlternativeAccuracySpeedup

Accuracy vs Speed

The accuracy (vertical axis) and speed (horizontal axis) of each alternatives. Up and to the right is better. The red square shows the initial program, and each blue circle shows an alternative.The line shows the best available speed-accuracy tradeoffs.

Bogosity?

Bogosity

Try it out?

Your Program's Arguments

Results

Enter valid numbers for all inputs

Target

Original6.1%
Target100.0%
Herbie100.0%
\[\frac{2 \cdot x}{\sqrt{1 + x} + \sqrt{1 - x}} \]

Derivation?

  1. Initial program 5.5%

    \[\sqrt{1 + x} - \sqrt{1 - x} \]

  2. Simplified5.5%

    \[\leadsto \color{blue}{\sqrt{x - -1} - \sqrt{1 - x}} \]
    Step-by-step derivation

    [Start]5.5%

    \[ \sqrt{1 + x} - \sqrt{1 - x} \]

    +-commutative [=>]5.5%

    \[ \sqrt{\color{blue}{x + 1}} - \sqrt{1 - x} \]

    metadata-eval [<=]5.5%

    \[ \sqrt{x + \color{blue}{\left(--1\right)}} - \sqrt{1 - x} \]

    sub-neg [<=]5.5%

    \[ \sqrt{\color{blue}{x - -1}} - \sqrt{1 - x} \]

  3. Taylor expanded in x around 0 100.0%

    \[\leadsto \color{blue}{x} \]

  4. Final simplification100.0%

    \[\leadsto x \]

Reproduce?

herbie shell --seed 2023263 
(FPCore (x)
  :name "bug333 (missed optimization)"
  :precision binary64
  :pre (and (<= -1.0 x) (<= x 1.0))

  :herbie-target
  (/ (* 2.0 x) (+ (sqrt (+ 1.0 x)) (sqrt (- 1.0 x))))

  (- (sqrt (+ 1.0 x)) (sqrt (- 1.0 x))))