tan-example (used to crash)

?

Percentage Accurate: 80.9% → 99.7%
Time: 1.3min
Precision: binary64
Cost: 32832

?

\[\left(\left(\left(x = 0 \lor 0.5884142 \leq x \land x \leq 505.5909\right) \land \left(-1.796658 \cdot 10^{+308} \leq y \land y \leq -9.425585 \cdot 10^{-310} \lor 1.284938 \cdot 10^{-309} \leq y \land y \leq 1.751224 \cdot 10^{+308}\right)\right) \land \left(-1.776707 \cdot 10^{+308} \leq z \land z \leq -8.599796 \cdot 10^{-310} \lor 3.293145 \cdot 10^{-311} \leq z \land z \leq 1.725154 \cdot 10^{+308}\right)\right) \land \left(-1.796658 \cdot 10^{+308} \leq a \land a \leq -9.425585 \cdot 10^{-310} \lor 1.284938 \cdot 10^{-309} \leq a \land a \leq 1.751224 \cdot 10^{+308}\right)\]
\[x + \left(\tan \left(y + z\right) - \tan a\right) \]
↓
\[x + \left(\frac{\tan y + \tan z}{1 - \tan y \cdot \tan z} - \tan a\right) \]
(FPCore (x y z a) :precision binary64 (+ x (- (tan (+ y z)) (tan a))))
↓
(FPCore (x y z a)
 :precision binary64
 (+ x (- (/ (+ (tan y) (tan z)) (- 1.0 (* (tan y) (tan z)))) (tan a))))
double code(double x, double y, double z, double a) {
	return x + (tan((y + z)) - tan(a));
}
↓
double code(double x, double y, double z, double a) {
	return x + (((tan(y) + tan(z)) / (1.0 - (tan(y) * tan(z)))) - tan(a));
}

real(8) function code(x, y, z, a)
    real(8), intent (in) :: x
    real(8), intent (in) :: y
    real(8), intent (in) :: z
    real(8), intent (in) :: a
    code = x + (tan((y + z)) - tan(a))
end function
↓
real(8) function code(x, y, z, a)
    real(8), intent (in) :: x
    real(8), intent (in) :: y
    real(8), intent (in) :: z
    real(8), intent (in) :: a
    code = x + (((tan(y) + tan(z)) / (1.0d0 - (tan(y) * tan(z)))) - tan(a))
end function

public static double code(double x, double y, double z, double a) {
	return x + (Math.tan((y + z)) - Math.tan(a));
}
↓
public static double code(double x, double y, double z, double a) {
	return x + (((Math.tan(y) + Math.tan(z)) / (1.0 - (Math.tan(y) * Math.tan(z)))) - Math.tan(a));
}

def code(x, y, z, a):
	return x + (math.tan((y + z)) - math.tan(a))
↓
def code(x, y, z, a):
	return x + (((math.tan(y) + math.tan(z)) / (1.0 - (math.tan(y) * math.tan(z)))) - math.tan(a))

function code(x, y, z, a)
	return Float64(x + Float64(tan(Float64(y + z)) - tan(a)))
end
↓
function code(x, y, z, a)
	return Float64(x + Float64(Float64(Float64(tan(y) + tan(z)) / Float64(1.0 - Float64(tan(y) * tan(z)))) - tan(a)))
end

function tmp = code(x, y, z, a)
	tmp = x + (tan((y + z)) - tan(a));
end
↓
function tmp = code(x, y, z, a)
	tmp = x + (((tan(y) + tan(z)) / (1.0 - (tan(y) * tan(z)))) - tan(a));
end

code[x_, y_, z_, a_] := N[(x + N[(N[Tan[N[(y + z), $MachinePrecision]], $MachinePrecision] - N[Tan[a], $MachinePrecision]), $MachinePrecision]), $MachinePrecision]
↓
code[x_, y_, z_, a_] := N[(x + N[(N[(N[(N[Tan[y], $MachinePrecision] + N[Tan[z], $MachinePrecision]), $MachinePrecision] / N[(1.0 - N[(N[Tan[y], $MachinePrecision] * N[Tan[z], $MachinePrecision]), $MachinePrecision]), $MachinePrecision]), $MachinePrecision] - N[Tan[a], $MachinePrecision]), $MachinePrecision]), $MachinePrecision]

x + \left(\tan \left(y + z\right) - \tan a\right)
↓
x + \left(\frac{\tan y + \tan z}{1 - \tan y \cdot \tan z} - \tan a\right)

Local Percentage Accuracy vs ?

The average percentage accuracy by input value. Horizontal axis shows value of an input variable; the variable is choosen in the title. Vertical axis is accuracy; higher is better. Red represent the original program, while blue represents Herbie's suggestion. These can be toggled with buttons below the plot. The line is an average while dots represent individual samples.

Herbie found 10 alternatives:

AlternativeAccuracySpeedup

Accuracy vs Speed

The accuracy (vertical axis) and speed (horizontal axis) of each alternatives. Up and to the right is better. The red square shows the initial program, and each blue circle shows an alternative.The line shows the best available speed-accuracy tradeoffs.

Bogosity?

Bogosity

Try it out?

Your Program's Arguments

Results

Enter valid numbers for all inputs

Derivation?

  1. Initial program 80.1%

    \[x + \left(\tan \left(y + z\right) - \tan a\right) \]

  2. Applied egg-rr99.9%

    \[\leadsto x + \left(\color{blue}{\left(\tan y + \tan z\right) \cdot \frac{1}{1 - \tan y \cdot \tan z}} - \tan a\right) \]
    Step-by-step derivation

    [Start]80.1%

    \[ x + \left(\tan \left(y + z\right) - \tan a\right) \]

    tan-sum [=>]99.8%

    \[ x + \left(\color{blue}{\frac{\tan y + \tan z}{1 - \tan y \cdot \tan z}} - \tan a\right) \]

    div-inv [=>]99.9%

    \[ x + \left(\color{blue}{\left(\tan y + \tan z\right) \cdot \frac{1}{1 - \tan y \cdot \tan z}} - \tan a\right) \]

  3. Simplified99.8%

    \[\leadsto x + \left(\color{blue}{\frac{\tan y + \tan z}{1 - \tan y \cdot \tan z}} - \tan a\right) \]
    Step-by-step derivation

    [Start]99.9%

    \[ x + \left(\left(\tan y + \tan z\right) \cdot \frac{1}{1 - \tan y \cdot \tan z} - \tan a\right) \]

    associate-*r/ [=>]99.8%

    \[ x + \left(\color{blue}{\frac{\left(\tan y + \tan z\right) \cdot 1}{1 - \tan y \cdot \tan z}} - \tan a\right) \]

    *-rgt-identity [=>]99.8%

    \[ x + \left(\frac{\color{blue}{\tan y + \tan z}}{1 - \tan y \cdot \tan z} - \tan a\right) \]

  4. Final simplification99.8%

    \[\leadsto x + \left(\frac{\tan y + \tan z}{1 - \tan y \cdot \tan z} - \tan a\right) \]

Alternatives

Alternative 1
Accuracy99.7%
Cost32832
\[x + \left(\frac{\tan y + \tan z}{1 - \tan y \cdot \tan z} - \tan a\right) \]
Alternative 2
Accuracy90.3%
Cost39625
\[\begin{array}{l} \mathbf{if}\;\tan a \leq -5 \cdot 10^{-5} \lor \neg \left(\tan a \leq 5 \cdot 10^{-22}\right):\\ \;\;\;\;x + \left(\tan \left(y + z\right) - \tan a\right)\\ \mathbf{else}:\\ \;\;\;\;\left(x + \left(\tan y + \tan z\right) \cdot \frac{1}{1 - \tan y \cdot \tan z}\right) - a\\ \end{array} \]
Alternative 3
Accuracy90.3%
Cost39497
\[\begin{array}{l} \mathbf{if}\;\tan a \leq -5 \cdot 10^{-5} \lor \neg \left(\tan a \leq 5 \cdot 10^{-22}\right):\\ \;\;\;\;x + \left(\tan \left(y + z\right) - \tan a\right)\\ \mathbf{else}:\\ \;\;\;\;\left(x + \frac{\tan y + \tan z}{1 - \tan y \cdot \tan z}\right) - a\\ \end{array} \]
Alternative 4
Accuracy71.2%
Cost26185
\[\begin{array}{l} \mathbf{if}\;\tan a \leq -5 \cdot 10^{-5} \lor \neg \left(\tan a \leq 2 \cdot 10^{-8}\right):\\ \;\;\;\;x + \left(\tan y - \tan a\right)\\ \mathbf{else}:\\ \;\;\;\;\left(x + \tan \left(y + z\right)\right) - a\\ \end{array} \]
Alternative 5
Accuracy57.4%
Cost19913
\[\begin{array}{l} \mathbf{if}\;\tan a \leq -5 \cdot 10^{-5} \lor \neg \left(\tan a \leq 2 \cdot 10^{-8}\right):\\ \;\;\;\;x + \left(y - \tan a\right)\\ \mathbf{else}:\\ \;\;\;\;\left(x + \tan \left(y + z\right)\right) - a\\ \end{array} \]
Alternative 6
Accuracy81.2%
Cost19648
\[\left(x + \left(\tan y + \tan z\right)\right) - \tan a \]
Alternative 7
Accuracy61.2%
Cost13508
\[\begin{array}{l} \mathbf{if}\;y + z \leq 2 \cdot 10^{-16}:\\ \;\;\;\;x + \left(\tan y - \tan a\right)\\ \mathbf{else}:\\ \;\;\;\;x + \left(\tan a + \tan \left(y + z\right)\right)\\ \end{array} \]
Alternative 8
Accuracy80.9%
Cost13248
\[x + \left(\tan \left(y + z\right) - \tan a\right) \]
Alternative 9
Accuracy38.0%
Cost6852
\[\begin{array}{l} \mathbf{if}\;y \leq -1.45:\\ \;\;\;\;x\\ \mathbf{else}:\\ \;\;\;\;x + \left(y - \tan a\right)\\ \end{array} \]
Alternative 10
Accuracy32.5%
Cost64
\[x \]

Reproduce?

herbie shell --seed 2023258 
(FPCore (x y z a)
  :name "tan-example (used to crash)"
  :precision binary64
  :pre (and (and (and (or (== x 0.0) (and (<= 0.5884142 x) (<= x 505.5909))) (or (and (<= -1.796658e+308 y) (<= y -9.425585e-310)) (and (<= 1.284938e-309 y) (<= y 1.751224e+308)))) (or (and (<= -1.776707e+308 z) (<= z -8.599796e-310)) (and (<= 3.293145e-311 z) (<= z 1.725154e+308)))) (or (and (<= -1.796658e+308 a) (<= a -9.425585e-310)) (and (<= 1.284938e-309 a) (<= a 1.751224e+308))))
  (+ x (- (tan (+ y z)) (tan a))))