bug333 (missed optimization)

Percentage Accurate: 8.5% → 99.0%
Time: 2.1s
Alternatives: 1
Speedup: 207.0×

Specification

?
\[-1 \leq x \land x \leq 1\]
\[\begin{array}{l} \\ \sqrt{1 + x} - \sqrt{1 - x} \end{array} \]
(FPCore (x) :precision binary64 (- (sqrt (+ 1.0 x)) (sqrt (- 1.0 x))))
double code(double x) {
	return sqrt((1.0 + x)) - sqrt((1.0 - x));
}

real(8) function code(x)
    real(8), intent (in) :: x
    code = sqrt((1.0d0 + x)) - sqrt((1.0d0 - x))
end function

public static double code(double x) {
	return Math.sqrt((1.0 + x)) - Math.sqrt((1.0 - x));
}

def code(x):
	return math.sqrt((1.0 + x)) - math.sqrt((1.0 - x))

function code(x)
	return Float64(sqrt(Float64(1.0 + x)) - sqrt(Float64(1.0 - x)))
end

function tmp = code(x)
	tmp = sqrt((1.0 + x)) - sqrt((1.0 - x));
end

code[x_] := N[(N[Sqrt[N[(1.0 + x), $MachinePrecision]], $MachinePrecision] - N[Sqrt[N[(1.0 - x), $MachinePrecision]], $MachinePrecision]), $MachinePrecision]

\begin{array}{l}

\\
\sqrt{1 + x} - \sqrt{1 - x}
\end{array}

Sampling outcomes in binary64 precision:

Local Percentage Accuracy vs ?

The average percentage accuracy by input value. Horizontal axis shows value of an input variable; the variable is choosen in the title. Vertical axis is accuracy; higher is better. Red represent the original program, while blue represents Herbie's suggestion. These can be toggled with buttons below the plot. The line is an average while dots represent individual samples.

Accuracy vs Speed?

Herbie found 1 alternatives:

AlternativeAccuracySpeedup
The accuracy (vertical axis) and speed (horizontal axis) of each alternatives. Up and to the right is better. The red square shows the initial program, and each blue circle shows an alternative.The line shows the best available speed-accuracy tradeoffs.

Initial Program: 8.5% accurate, 1.0× speedup?

\[\begin{array}{l} \\ \sqrt{1 + x} - \sqrt{1 - x} \end{array} \]
(FPCore (x) :precision binary64 (- (sqrt (+ 1.0 x)) (sqrt (- 1.0 x))))
double code(double x) {
	return sqrt((1.0 + x)) - sqrt((1.0 - x));
}

real(8) function code(x)
    real(8), intent (in) :: x
    code = sqrt((1.0d0 + x)) - sqrt((1.0d0 - x))
end function

public static double code(double x) {
	return Math.sqrt((1.0 + x)) - Math.sqrt((1.0 - x));
}

def code(x):
	return math.sqrt((1.0 + x)) - math.sqrt((1.0 - x))

function code(x)
	return Float64(sqrt(Float64(1.0 + x)) - sqrt(Float64(1.0 - x)))
end

function tmp = code(x)
	tmp = sqrt((1.0 + x)) - sqrt((1.0 - x));
end

code[x_] := N[(N[Sqrt[N[(1.0 + x), $MachinePrecision]], $MachinePrecision] - N[Sqrt[N[(1.0 - x), $MachinePrecision]], $MachinePrecision]), $MachinePrecision]

\begin{array}{l}

\\
\sqrt{1 + x} - \sqrt{1 - x}
\end{array}

Alternative 1: 99.0% accurate, 207.0× speedup?

\[\begin{array}{l} \\ x \end{array} \]
(FPCore (x) :precision binary64 x)
double code(double x) {
	return x;
}

real(8) function code(x)
    real(8), intent (in) :: x
    code = x
end function

public static double code(double x) {
	return x;
}

def code(x):
	return x

function code(x)
	return x
end

function tmp = code(x)
	tmp = x;
end

code[x_] := x

\begin{array}{l}

\\
x
\end{array}
Derivation

  1. Initial program 7.4%

    \[\sqrt{1 + x} - \sqrt{1 - x} \]
  2. Step-by-step derivation

    1. +-commutative7.4%

      \[\leadsto \sqrt{\color{blue}{x + 1}} - \sqrt{1 - x} \]

    2. metadata-eval7.4%

      \[\leadsto \sqrt{x + \color{blue}{\left(--1\right)}} - \sqrt{1 - x} \]

    3. sub-neg7.4%

      \[\leadsto \sqrt{\color{blue}{x - -1}} - \sqrt{1 - x} \]

  3. Simplified7.4%

    \[\leadsto \color{blue}{\sqrt{x - -1} - \sqrt{1 - x}} \]

  4. Taylor expanded in x around 0 100.0%

    \[\leadsto \color{blue}{x} \]

  5. Final simplification100.0%

    \[\leadsto x \]

Developer target: 100.0% accurate, 1.0× speedup?

\[\begin{array}{l} \\ \frac{2 \cdot x}{\sqrt{1 + x} + \sqrt{1 - x}} \end{array} \]
(FPCore (x)
 :precision binary64
 (/ (* 2.0 x) (+ (sqrt (+ 1.0 x)) (sqrt (- 1.0 x)))))
double code(double x) {
	return (2.0 * x) / (sqrt((1.0 + x)) + sqrt((1.0 - x)));
}

real(8) function code(x)
    real(8), intent (in) :: x
    code = (2.0d0 * x) / (sqrt((1.0d0 + x)) + sqrt((1.0d0 - x)))
end function

public static double code(double x) {
	return (2.0 * x) / (Math.sqrt((1.0 + x)) + Math.sqrt((1.0 - x)));
}

def code(x):
	return (2.0 * x) / (math.sqrt((1.0 + x)) + math.sqrt((1.0 - x)))

function code(x)
	return Float64(Float64(2.0 * x) / Float64(sqrt(Float64(1.0 + x)) + sqrt(Float64(1.0 - x))))
end

function tmp = code(x)
	tmp = (2.0 * x) / (sqrt((1.0 + x)) + sqrt((1.0 - x)));
end

code[x_] := N[(N[(2.0 * x), $MachinePrecision] / N[(N[Sqrt[N[(1.0 + x), $MachinePrecision]], $MachinePrecision] + N[Sqrt[N[(1.0 - x), $MachinePrecision]], $MachinePrecision]), $MachinePrecision]), $MachinePrecision]

\begin{array}{l}

\\
\frac{2 \cdot x}{\sqrt{1 + x} + \sqrt{1 - x}}
\end{array}

Reproduce

?
herbie shell --seed 2023256 
(FPCore (x)
  :name "bug333 (missed optimization)"
  :precision binary64
  :pre (and (<= -1.0 x) (<= x 1.0))

  :herbie-target
  (/ (* 2.0 x) (+ (sqrt (+ 1.0 x)) (sqrt (- 1.0 x))))

  (- (sqrt (+ 1.0 x)) (sqrt (- 1.0 x))))