bug366 (missed optimization)

Percentage Accurate: 45.1% → 100.0%
Time: 1.5s
Alternatives: 2
Speedup: 111.0×

Specification

?
\[\begin{array}{l} \\ \sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \end{array} \]
(FPCore (x y z) :precision binary64 (sqrt (+ (* x x) (+ (* y y) (* z z)))))
double code(double x, double y, double z) {
	return sqrt(((x * x) + ((y * y) + (z * z))));
}

real(8) function code(x, y, z)
    real(8), intent (in) :: x
    real(8), intent (in) :: y
    real(8), intent (in) :: z
    code = sqrt(((x * x) + ((y * y) + (z * z))))
end function

public static double code(double x, double y, double z) {
	return Math.sqrt(((x * x) + ((y * y) + (z * z))));
}

def code(x, y, z):
	return math.sqrt(((x * x) + ((y * y) + (z * z))))

function code(x, y, z)
	return sqrt(Float64(Float64(x * x) + Float64(Float64(y * y) + Float64(z * z))))
end

function tmp = code(x, y, z)
	tmp = sqrt(((x * x) + ((y * y) + (z * z))));
end

code[x_, y_, z_] := N[Sqrt[N[(N[(x * x), $MachinePrecision] + N[(N[(y * y), $MachinePrecision] + N[(z * z), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]], $MachinePrecision]

\begin{array}{l}

\\
\sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)}
\end{array}

Sampling outcomes in binary64 precision:

Local Percentage Accuracy vs ?

The average percentage accuracy by input value. Horizontal axis shows value of an input variable; the variable is choosen in the title. Vertical axis is accuracy; higher is better. Red represent the original program, while blue represents Herbie's suggestion. These can be toggled with buttons below the plot. The line is an average while dots represent individual samples.

Accuracy vs Speed?

Herbie found 2 alternatives:

AlternativeAccuracySpeedup
The accuracy (vertical axis) and speed (horizontal axis) of each alternatives. Up and to the right is better. The red square shows the initial program, and each blue circle shows an alternative.The line shows the best available speed-accuracy tradeoffs.

Initial Program: 45.1% accurate, 1.0× speedup?

\[\begin{array}{l} \\ \sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \end{array} \]
(FPCore (x y z) :precision binary64 (sqrt (+ (* x x) (+ (* y y) (* z z)))))
double code(double x, double y, double z) {
	return sqrt(((x * x) + ((y * y) + (z * z))));
}

real(8) function code(x, y, z)
    real(8), intent (in) :: x
    real(8), intent (in) :: y
    real(8), intent (in) :: z
    code = sqrt(((x * x) + ((y * y) + (z * z))))
end function

public static double code(double x, double y, double z) {
	return Math.sqrt(((x * x) + ((y * y) + (z * z))));
}

def code(x, y, z):
	return math.sqrt(((x * x) + ((y * y) + (z * z))))

function code(x, y, z)
	return sqrt(Float64(Float64(x * x) + Float64(Float64(y * y) + Float64(z * z))))
end

function tmp = code(x, y, z)
	tmp = sqrt(((x * x) + ((y * y) + (z * z))));
end

code[x_, y_, z_] := N[Sqrt[N[(N[(x * x), $MachinePrecision] + N[(N[(y * y), $MachinePrecision] + N[(z * z), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]], $MachinePrecision]

\begin{array}{l}

\\
\sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)}
\end{array}

Alternative 1: 100.0% accurate, 1.1× speedup?

\[\begin{array}{l} x = |x|\\ y = |y|\\ z = |z|\\ [x, y, z] = \mathsf{sort}([x, y, z])\\ \\ \mathsf{hypot}\left(z, y\right) \end{array} \]
NOTE: x should be positive before calling this function
NOTE: y should be positive before calling this function
NOTE: z should be positive before calling this function
NOTE: x, y, and z should be sorted in increasing order before calling this function.
(FPCore (x y z) :precision binary64 (hypot z y))
x = abs(x);
y = abs(y);
z = abs(z);
assert(x < y && y < z);
double code(double x, double y, double z) {
	return hypot(z, y);
}

x = Math.abs(x);
y = Math.abs(y);
z = Math.abs(z);
assert x < y && y < z;
public static double code(double x, double y, double z) {
	return Math.hypot(z, y);
}

x = abs(x)
y = abs(y)
z = abs(z)
[x, y, z] = sort([x, y, z])
def code(x, y, z):
	return math.hypot(z, y)

x = abs(x)
y = abs(y)
z = abs(z)
x, y, z = sort([x, y, z])
function code(x, y, z)
	return hypot(z, y)
end

x = abs(x)
y = abs(y)
z = abs(z)
x, y, z = num2cell(sort([x, y, z])){:}
function tmp = code(x, y, z)
	tmp = hypot(z, y);
end

NOTE: x should be positive before calling this function
NOTE: y should be positive before calling this function
NOTE: z should be positive before calling this function
NOTE: x, y, and z should be sorted in increasing order before calling this function.
code[x_, y_, z_] := N[Sqrt[z ^ 2 + y ^ 2], $MachinePrecision]

\begin{array}{l}
x = |x|\\
y = |y|\\
z = |z|\\
[x, y, z] = \mathsf{sort}([x, y, z])\\
\\
\mathsf{hypot}\left(z, y\right)
\end{array}
Derivation

  1. Initial program 41.5%

    \[\sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \]

  2. Taylor expanded in x around 0 29.6%

    \[\leadsto \color{blue}{\sqrt{{z}^{2} + {y}^{2}}} \]
  3. Step-by-step derivation

    1. unpow229.6%

      \[\leadsto \sqrt{\color{blue}{z \cdot z} + {y}^{2}} \]

    2. unpow229.6%

      \[\leadsto \sqrt{z \cdot z + \color{blue}{y \cdot y}} \]

    3. hypot-def67.3%

      \[\leadsto \color{blue}{\mathsf{hypot}\left(z, y\right)} \]

  4. Simplified67.3%

    \[\leadsto \color{blue}{\mathsf{hypot}\left(z, y\right)} \]

  5. Final simplification67.3%

    \[\leadsto \mathsf{hypot}\left(z, y\right) \]

Alternative 2: 98.6% accurate, 111.0× speedup?

\[\begin{array}{l} x = |x|\\ y = |y|\\ z = |z|\\ [x, y, z] = \mathsf{sort}([x, y, z])\\ \\ z \end{array} \]
NOTE: x should be positive before calling this function
NOTE: y should be positive before calling this function
NOTE: z should be positive before calling this function
NOTE: x, y, and z should be sorted in increasing order before calling this function.
(FPCore (x y z) :precision binary64 z)
x = abs(x);
y = abs(y);
z = abs(z);
assert(x < y && y < z);
double code(double x, double y, double z) {
	return z;
}

NOTE: x should be positive before calling this function
NOTE: y should be positive before calling this function
NOTE: z should be positive before calling this function
NOTE: x, y, and z should be sorted in increasing order before calling this function.
real(8) function code(x, y, z)
    real(8), intent (in) :: x
    real(8), intent (in) :: y
    real(8), intent (in) :: z
    code = z
end function

x = Math.abs(x);
y = Math.abs(y);
z = Math.abs(z);
assert x < y && y < z;
public static double code(double x, double y, double z) {
	return z;
}

x = abs(x)
y = abs(y)
z = abs(z)
[x, y, z] = sort([x, y, z])
def code(x, y, z):
	return z

x = abs(x)
y = abs(y)
z = abs(z)
x, y, z = sort([x, y, z])
function code(x, y, z)
	return z
end

x = abs(x)
y = abs(y)
z = abs(z)
x, y, z = num2cell(sort([x, y, z])){:}
function tmp = code(x, y, z)
	tmp = z;
end

NOTE: x should be positive before calling this function
NOTE: y should be positive before calling this function
NOTE: z should be positive before calling this function
NOTE: x, y, and z should be sorted in increasing order before calling this function.
code[x_, y_, z_] := z

\begin{array}{l}
x = |x|\\
y = |y|\\
z = |z|\\
[x, y, z] = \mathsf{sort}([x, y, z])\\
\\
z
\end{array}
Derivation

  1. Initial program 41.5%

    \[\sqrt{x \cdot x + \left(y \cdot y + z \cdot z\right)} \]

  2. Taylor expanded in z around inf 16.2%

    \[\leadsto \color{blue}{z} \]

  3. Final simplification16.2%

    \[\leadsto z \]

Developer target: 100.0% accurate, 0.5× speedup?

\[\begin{array}{l} \\ \mathsf{hypot}\left(x, \mathsf{hypot}\left(y, z\right)\right) \end{array} \]
(FPCore (x y z) :precision binary64 (hypot x (hypot y z)))
double code(double x, double y, double z) {
	return hypot(x, hypot(y, z));
}

public static double code(double x, double y, double z) {
	return Math.hypot(x, Math.hypot(y, z));
}

def code(x, y, z):
	return math.hypot(x, math.hypot(y, z))

function code(x, y, z)
	return hypot(x, hypot(y, z))
end

function tmp = code(x, y, z)
	tmp = hypot(x, hypot(y, z));
end

code[x_, y_, z_] := N[Sqrt[x ^ 2 + N[Sqrt[y ^ 2 + z ^ 2], $MachinePrecision] ^ 2], $MachinePrecision]

\begin{array}{l}

\\
\mathsf{hypot}\left(x, \mathsf{hypot}\left(y, z\right)\right)
\end{array}

Reproduce

?
herbie shell --seed 2023203 
(FPCore (x y z)
  :name "bug366 (missed optimization)"
  :precision binary64

  :herbie-target
  (hypot x (hypot y z))

  (sqrt (+ (* x x) (+ (* y y) (* z z)))))