bug366, discussion (missed optimization)

Average Error: 31.1 → 0.6

Time: 3.6s

Precision: binary64

Cost: 708

Math

\[\sqrt{a \cdot a - b \cdot b} \]

↓

\[\begin{array}{l} \mathbf{if}\;a \leq 3.003859903345788 \cdot 10^{-290}:\\ \;\;\;\;-a\\ \mathbf{else}:\\ \;\;\;\;a + -0.5 \cdot \left(b \cdot \frac{b}{a}\right)\\ \end{array} \]

FPCore

(FPCore (a b) :precision binary64 (sqrt (- (* a a) (* b b))))

↓

(FPCore (a b)
 :precision binary64
 (if (<= a 3.003859903345788e-290) (- a) (+ a (* -0.5 (* b (/ b a))))))

C

double code(double a, double b) {
	return sqrt(((a * a) - (b * b)));
}

↓

double code(double a, double b) {
	double tmp;
	if (a <= 3.003859903345788e-290) {
		tmp = -a;
	} else {
		tmp = a + (-0.5 * (b * (b / a)));
	}
	return tmp;
}

Fortran

real(8) function code(a, b)
    real(8), intent (in) :: a
    real(8), intent (in) :: b
    code = sqrt(((a * a) - (b * b)))
end function

↓

real(8) function code(a, b)
    real(8), intent (in) :: a
    real(8), intent (in) :: b
    real(8) :: tmp
    if (a <= 3.003859903345788d-290) then
        tmp = -a
    else
        tmp = a + ((-0.5d0) * (b * (b / a)))
    end if
    code = tmp
end function

Java

public static double code(double a, double b) {
	return Math.sqrt(((a * a) - (b * b)));
}

↓

public static double code(double a, double b) {
	double tmp;
	if (a <= 3.003859903345788e-290) {
		tmp = -a;
	} else {
		tmp = a + (-0.5 * (b * (b / a)));
	}
	return tmp;
}

Python

def code(a, b):
	return math.sqrt(((a * a) - (b * b)))

↓

def code(a, b):
	tmp = 0
	if a <= 3.003859903345788e-290:
		tmp = -a
	else:
		tmp = a + (-0.5 * (b * (b / a)))
	return tmp

Julia

function code(a, b)
	return sqrt(Float64(Float64(a * a) - Float64(b * b)))
end

↓

function code(a, b)
	tmp = 0.0
	if (a <= 3.003859903345788e-290)
		tmp = Float64(-a);
	else
		tmp = Float64(a + Float64(-0.5 * Float64(b * Float64(b / a))));
	end
	return tmp
end

MATLAB

function tmp = code(a, b)
	tmp = sqrt(((a * a) - (b * b)));
end

↓

function tmp_2 = code(a, b)
	tmp = 0.0;
	if (a <= 3.003859903345788e-290)
		tmp = -a;
	else
		tmp = a + (-0.5 * (b * (b / a)));
	end
	tmp_2 = tmp;
end

Wolfram

code[a_, b_] := N[Sqrt[N[(N[(a * a), $MachinePrecision] - N[(b * b), $MachinePrecision]), $MachinePrecision]], $MachinePrecision]

↓

code[a_, b_] := If[LessEqual[a, 3.003859903345788e-290], (-a), N[(a + N[(-0.5 * N[(b * N[(b / a), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]), $MachinePrecision]]

Target

Original	31.1
Target	0.5
Herbie	0.6

\[\sqrt{\left|a\right| + \left|b\right|} \cdot \sqrt{\left|a\right| - \left|b\right|} \]

Derivation

1. Split input into 2 regimes

2. if a < 3.00385990334578772e-290

   1. Initial program 31.0

      \[\sqrt{a \cdot a - b \cdot b} \]

   2. Taylor expanded in a around -inf 0.8

      \[\leadsto \color{blue}{-1 \cdot a} \]

   3. Simplified 0.8

      \[\leadsto \color{blue}{-a} \]
      Proof

      [Start] 0.8	\[ -1 \cdot a \]
      mul-1-neg [=>] 0.8	\[ \color{blue}{-a} \]

   if 3.00385990334578772e-290 < a

   1. Initial program 31.2

      \[\sqrt{a \cdot a - b \cdot b} \]

   2. Taylor expanded in a around inf 4.1

      \[\leadsto \color{blue}{a + -0.5 \cdot \frac{{b}^{2}}{a}} \]

   3. Simplified 4.1

      \[\leadsto \color{blue}{a + -0.5 \cdot \frac{b \cdot b}{a}} \]
      Proof

      [Start] 4.1	\[ a + -0.5 \cdot \frac{{b}^{2}}{a} \]
      unpow2 [=>] 4.1	\[ a + -0.5 \cdot \frac{\color{blue}{b \cdot b}}{a} \]

   4. Applied egg-rr 0.3

      \[\leadsto a + -0.5 \cdot \color{blue}{\left(\frac{b}{a} \cdot b\right)} \]
3. Recombined 2 regimes into one program.

4. Final simplification 0.6

   \[\leadsto \begin{array}{l} \mathbf{if}\;a \leq 3.003859903345788 \cdot 10^{-290}:\\ \;\;\;\;-a\\ \mathbf{else}:\\ \;\;\;\;a + -0.5 \cdot \left(b \cdot \frac{b}{a}\right)\\ \end{array} \]

Alternatives

Alternative 1
Error	0.7
Cost	260

\[\begin{array}{l} \mathbf{if}\;a \leq 3.003859903345788 \cdot 10^{-290}:\\ \;\;\;\;-a\\ \mathbf{else}:\\ \;\;\;\;a\\ \end{array} \]

Alternative 2
Error	31.9
Cost	64

\[a \]

Reproduce

herbie shell --seed 2023054 
(FPCore (a b)
  :name "bug366, discussion (missed optimization)"
  :precision binary64

  :herbie-target
  (* (sqrt (+ (fabs a) (fabs b))) (sqrt (- (fabs a) (fabs b))))

  (sqrt (- (* a a) (* b b))))